fix: support deeply nested pnpm virtual store node_modules paths in resolveAndRunNgcc #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
requested changes
Aug 10, 2022
There was a problem hiding this comment.
Sorry to be a stickler, but you you update the commit message to describe what's fixed and why it was broken rather than the "what" of the code change? This will help anyone going through the commits know why this change was made (otherwise, there's no context other than our conversation on slack)
gregmagolan
force-pushed
the
index_of
branch
2 times, most recently
from
f9e5e3a
to
6b11195
Compare
gregmagolan
changed the title
gregmagolan
changed the title
…esolveAndRunNgcc Uses indexOf instead of lastIndexOf in resolveAndRunNgcc. This resolves the case where a user is using pnpm and ngcc is resolved through symlinks to a deeply nested virtual store node_modules location: `some/user/path/node_modules/.pnpm/@angular/compiler-cli@1.2.3/node_modules/@angular/compiler-cli/...` lastIndexOf would resolve to `some/user/path/node_modules/.pnpm/@angular/compiler-cli@1.2.3` which is incorrect. indexOf gets you to the desired `some/user/path`
atscott
approved these changes
Aug 10, 2022
atscott
added
target: patch
atscott
pushed a commit
that referenced
this pull request
Aug 10, 2022
…esolveAndRunNgcc (#1742) Uses indexOf instead of lastIndexOf in resolveAndRunNgcc. This resolves the case where a user is using pnpm and ngcc is resolved through symlinks to a deeply nested virtual store node_modules location: `some/user/path/node_modules/.pnpm/@angular/compiler-cli@1.2.3/node_modules/@angular/compiler-cli/...` lastIndexOf would resolve to `some/user/path/node_modules/.pnpm/@angular/compiler-cli@1.2.3` which is incorrect. indexOf gets you to the desired `some/user/path` (cherry picked from commit 511218f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses indexOf instead of lastIndexOf in resolveAndRunNgcc.
This resolves the case where a user is using pnpm and ngcc is resolved through symlinks to a deeply nested virtual store node_modules location:
some/user/path/node_modules/.pnpm/@angular/compiler-cli@1.2.3/node_modules/@angular/compiler-cli/...lastIndexOf would resolve to
some/user/path/node_modules/.pnpm/@angular/compiler-cli@1.2.3which is incorrect. indexOf gets you to the desiredsome/user/path