fix(server): send diagnostic range to the Angular language service wh… #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en fixing code errors
This will make the fix error code simple, the range the fix error code get is always
the start and end of the diagnostic. For example, `<span>{{title}}</span>`, the `title` is
the missing member of component. When the range the user selects is from the start of `<span>`
to the end of `</span>`, the fix error code needs to check the start of the diagnostic.
|
Sorry for the delay -- I was at ng-conf last week. Let me have a look. |
dylhunn
approved these changes
Sep 8, 2022
dylhunn
added
target: patch
|
This has merge conflicts with the patch branch -- it will need another rebased PR if you want this to land in a patch version. But we're good for main. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en fixing code errors
This will make the fix error code simple, the range the fix error code get is always
the start and end of the diagnostic. For example,
<span>{{title}}</span>, thetitleisthe missing member of component. When the range the user selects is from the start of
<span>to the end of
</span>, the fix error code needs to check the start of the diagnostic.