feat(server): provide folding ranges for inline templates #1779
Conversation
atscott
added
feature
target: minor
atscott
force-pushed
the
foldingRanges
branch
3 times, most recently
from
6c311b8
to
b2ec117
Compare
To support legacy view engine, we install an old version of the language server into the vsix.
The esbuild configuration is now managed in the BUILD.bazel rules.
atscott
force-pushed
the
foldingRanges
branch
from
b2ec117
to
67f4fe7
Compare
Following the embedded language support documentation, this commit provides folding ranges for inline templates in typescript files. This feature is provided in the language server so other editors that use the @angular/language-server package can make use of the feature as well. https://code.visualstudio.com/api/language-extensions/embedded-languages fixes angular#852
atscott
force-pushed
the
foldingRanges
branch
from
67f4fe7
to
9783009
Compare
|
@ivanwonder Would you mind reviewing this change? |
|
Ok, I will review this soon. |
| return classDeclNode; | ||
| } | ||
|
|
||
| export function findAllMatchingNodes( |
There was a problem hiding this comment.
nit: I think this can be moved into NgLanguageService(for example, getAllComponentLocationsInFile), and reused for styles.
There was a problem hiding this comment.
In the future, we maybe need this.🤔
There was a problem hiding this comment.
Added some tests. Good thought.
As for moving it to the NgLanguageService, I do like the idea in general. Let's do it as a follow-up refactor? We do pretty much have these exact functions: https://github.com/angular/angular/blob/54e32dad3e130a64e0c312746b67229d8aeb785c/packages/language-service/src/language_service.ts#L594-L598
I don't know what exactly we'd want to expose as public API though.
There was a problem hiding this comment.
Yes, Let's do it in the follow-up PR.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Following the embedded language support documentation, this commit provides folding ranges for inline templates in typescript files. This feature is provided in the language server so other editors that use the @angular/language-server package can make use of the feature as well.
https://code.visualstudio.com/api/language-extensions/embedded-languages
fixes #852