-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server): filter unsupported code action #1834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! We definitely didn't have the historical context to know about this option.
Thanks Ivan. This would have been really hard to figure out! |
Now the Angular code action provider only supports `QuickFix`. If leave the `codeActionKinds` empty, all action requests will be sent to the Angular language service, especially for the action before saving the file, the Angular code action provider will try to fix all errors in the whole file, it's expensive. Fixes angular#1828
b3da17f
to
7569f21
Compare
BTW, the user also can send the quick fix action before saving, but I think it's not expected. For example, In the built-in typescript extension. "editor.codeActionsOnSave": {
"quickfix": true,
} class Test {
test() {
this.missingMember
}
} After the user saves the file. class Test {
[x: string]: any;
missingMember: any;
test() {
this.missingMember
}
} |
Now the Angular code action provider only supports `QuickFix`. If leave the `codeActionKinds` empty, all action requests will be sent to the Angular language service, especially for the action before saving the file, the Angular code action provider will try to fix all errors in the whole file, it's expensive. Fixes #1828 (cherry picked from commit 38729c9)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Now the Angular code action provider only supports
QuickFix
. If leave thecodeActionKinds
empty, all action requests will be sent to the Angular language service, especially for the action before saving the file, the Angular code action provider will try to fix all errors in the whole file, it's expensive.Fixes #1828