Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(extension): Ensure Angular code actions are only retrieved in An… #1842

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

atscott
Copy link
Collaborator

@atscott atscott commented Dec 20, 2022

…gular contexts

This change extends the short-circuit logic that has been enabled for other features to the code actions as well.

Original issue was #1176

New performance issues have been reported recently (#1840), likely due to the code fixes for auto imports.

…gular contexts

This change extends the short-circuit logic that has been enabled for
other features to the code actions as well.

Original issue was angular#1176

New performance issues have been reported recently (angular#1840), likely due
to the code fixes for auto imports.
@atscott atscott added the target: patch This PR is targeted for the next patch release label Dec 20, 2022
@atscott atscott requested a review from dylhunn December 20, 2022 23:54
@dylhunn dylhunn added the action: merge Ready to merge label Dec 29, 2022
@dylhunn dylhunn merged commit 13d165c into angular:main Dec 29, 2022
dylhunn pushed a commit that referenced this pull request Dec 29, 2022
…gular contexts (#1842)

This change extends the short-circuit logic that has been enabled for
other features to the code actions as well.

Original issue was #1176

New performance issues have been reported recently (#1840), likely due
to the code fixes for auto imports.

(cherry picked from commit 13d165c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants