Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to disable code actions #1849

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

atscott
Copy link
Collaborator

@atscott atscott commented Jan 9, 2023

Code actions require additional analysis and developers may want to disable them for performance reasons.

Resolves #1840

@atscott atscott added the target: minor This PR is targeted for the next minor release label Jan 9, 2023
@atscott atscott requested a review from dylhunn January 9, 2023 20:41
Code actions require additional analysis and developers may want to
disable them for performance reasons.

Resolves angular#1840
@atscott atscott added the action: merge Ready to merge label Jan 17, 2023
@atscott atscott merged commit 3453361 into angular:main Jan 17, 2023
atscott added a commit to atscott/vscode-ng-language-service that referenced this pull request Feb 2, 2023
This reverts commit 3453361.

This feature was only added as a potential mitigation for performance
issues in the v15 release. These performance issues have been
unreproducable by the team and disabling quick fixes using this feature
has not been confirmed to resolve the problem from developers
expeiencing the issue.
dylhunn pushed a commit that referenced this pull request Feb 2, 2023
This reverts commit 3453361.

This feature was only added as a potential mitigation for performance
issues in the v15 release. These performance issues have been
unreproducable by the team and disabling quick fixes using this feature
has not been confirmed to resolve the problem from developers
expeiencing the issue.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge detected: feature target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular Language Service v15.0.3 causes intellisense to be so slow that vscode becomes unusable
2 participants