fix(server): Fall back to bundled TS version if specified TSDK is too… #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… old We attempt to use the version of typescript defined in the extension options. However, this might be too old for the required version in the bundled Angular compiler. If this happens, we now attempt to resolve the version from the bundled one instead (and print a warning to the output). Fixes angular#1855
dylhunn
approved these changes
Feb 17, 2023
atscott
added a commit
that referenced
this pull request
Feb 21, 2023
… old (#1863) We attempt to use the version of typescript defined in the extension options. However, this might be too old for the required version in the bundled Angular compiler. If this happens, we now attempt to resolve the version from the bundled one instead (and print a warning to the output). Fixes #1855 (cherry picked from commit 406dac9)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… old
We attempt to use the version of typescript defined in the extension options. However, this might be too old for the required version in the bundled Angular compiler. If this happens, we now attempt to resolve the version from the bundled one instead (and print a warning to the output).
Fixes #1855