fix(server): Generate help message before using attempting to resolve… #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… any require statements The `requireOverride` resolves TSServer from the command line arguments. The `createLogger` import will end up executing this code. As a result, we need to parse and show the help message before the logger import or the --help option will fail due to a failure to resolve the TS dependency. fixes angular#1899
dylhunn
approved these changes
Aug 11, 2023
atscott
added a commit
that referenced
this pull request
Aug 11, 2023
… any require statements (#1910) The `requireOverride` resolves TSServer from the command line arguments. The `createLogger` import will end up executing this code. As a result, we need to parse and show the help message before the logger import or the --help option will fail due to a failure to resolve the TS dependency. fixes #1899 (cherry picked from commit 6d3267d)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… any require statements
The
requireOverrideresolves TSServer from the command line arguments. ThecreateLoggerimport will end up executing this code. As a result, we need to parse and show the help message before the logger import or the --help option will fail due to a failure to resolve the TS dependency.fixes #1899