Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support block completions #1937

Merged
merged 1 commit into from
Oct 10, 2023
Merged

feat: support block completions #1937

merged 1 commit into from
Oct 10, 2023

Conversation

dylhunn
Copy link
Collaborator

@dylhunn dylhunn commented Oct 9, 2023

Two changes are necessary to support autocompletion of block keywords:

  1. The @ keyword causes immediate completion
  2. The new block completion item kind maps onto the keyword icon

Two changes are necessary to support autocompletion of block keywords:
1. The `@` keyword causes immediate completion
2. The new block completion item kind maps onto the keyword icon
@dylhunn dylhunn added the target: major This PR is targeted for the next major release label Oct 9, 2023
@dylhunn dylhunn requested a review from atscott October 9, 2023 21:55
@dylhunn
Copy link
Collaborator Author

dylhunn commented Oct 9, 2023

(Related to angular/angular#52121)

@dylhunn dylhunn added the action: merge Ready to merge label Oct 10, 2023
@atscott atscott merged commit d53ce2e into angular:main Oct 10, 2023
5 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge detected: feature target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants