fix(syntaxes): Use expression.ng instead of JS for block expressions #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
force-pushed
the
blockexpression
branch
from
9e69905
to
a604a93
Compare
dylhunn
approved these changes
Nov 8, 2023
JS syntax has certain expectations for statements that do not hold true inside Angular template expressions. A missing trailing `;` in a variable assignment in a `for` expression will cause the javascript to never terminate. This commit updates the expression to use `expression.ng` instead. fixes angular#1957
atscott
force-pushed
the
blockexpression
branch
from
a604a93
to
918f9c2
Compare
atscott
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS syntax has certain expectations for statements that do not hold true inside Angular template expressions. A missing trailing
;in a variable assignment in aforexpression will cause the javascript to never terminate. This commit updates the expression to useexpression.nginstead.fixes #1957