fix: match external templates to project on startup #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
changed the title
ayazhafiz
reviewed
Nov 20, 2020
kyliau
force-pushed
the
external-template-project-matching
branch
6 times, most recently
from
072534c
to
96ee0e8
Compare
ayazhafiz
reviewed
Nov 20, 2020
kyliau
force-pushed
the
external-template-project-matching
branch
2 times, most recently
from
1ca74ed
to
cc2ef8c
Compare
atscott
approved these changes
Nov 25, 2020
| return; | ||
| } | ||
| const fileName = project.getRootScriptInfos()[0].fileName; | ||
| // Getting semantic diagnostics will trigger a global analysis. |
There was a problem hiding this comment.
Is it that getting semantic diagnostics always triggers global analysis or is this just because we're triggering diagnostics on a root file?
There was a problem hiding this comment.
Getting semantic diagnostics always triggers global analysis, because a new compiler is created every time. Technically any file will do, not just root files, but the file must be part of the project, so root file is a convenient candidate.
kyliau
force-pushed
the
external-template-project-matching
branch
from
cc2ef8c
to
fede6e6
Compare
Currently, Ivy LS is not able to match external projects to their external templates if no TS files are open. This is because Ivy LS does not implement `getExternalFiles()`. To fix this, we take a different route: After ngcc has run, we send diagnostics for all the open files. But in the case where all open files are external templates, we first get diagnostics for a root TS file, then process the rest. Processing a root TS file triggers a global analysis, during which we match the external templates to their project. For a more detailed explanation, see https://github.com/angular/vscode-ng-language-service/wiki/Project-Matching-for-External-Templates Close angular#976
kyliau
force-pushed
the
external-template-project-matching
branch
from
fede6e6
to
1cffa6a
Compare
ayazhafiz
approved these changes
Dec 1, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Ivy LS is not able to match external projects to their external
templates if no TS files are open. This is because Ivy LS does not implement
getExternalFiles().To fix this, we take a different route:
After ngcc has run, we send diagnostics for all the open files. But in the
case where all open files are external templates, we first get diagnostics
for a root TS file, then process the rest. Processing a root TS file triggers
a global analysis, during which we match the external templates to their
project.
For a more detailed explanation, see
https://github.com/angular/vscode-ng-language-service/wiki/Project-Matching-for-External-Templates