refactor(ngdart)!: rename and remove deprecated values from ChangeDet…

…ectionStrategy and APP_ID (#41) All values provided by the static `ChangeDetectionStrategy` class are now members of the `ChangeDetectionStrategy` enum. The `default` change detection strategy is now removed in favor of `checkAlways` since they have identical behaviors. In addition, the `APP_ID` injection token is renamed to `appId` to conform to the idiomatic Dart language style.
angulardart-community · Mar 16, 2023 · 3c5523a · 3c5523a
1 parent 063c91e
commit 3c5523a
Show file tree

Hide file tree

Showing 34 changed files with 150 additions and 405 deletions.
diff --git a/_tests/test/compiler_integration/invalid_change_detection_link_test.dart b/_tests/test/compiler_integration/invalid_change_detection_link_test.dart
@@ -19,7 +19,7 @@ void main() {
         @Component(
           selector: 'test',
           template: '',
-          changeDetection: ChangeDetectionStrategy.OnPush,
+          changeDetection: ChangeDetectionStrategy.onPush,
         )
         class OnPushComponent {}
       """);

diff --git a/_tests/test/compiler_integration/on_push_validation_test.dart b/_tests/test/compiler_integration/on_push_validation_test.dart
@@ -24,15 +24,15 @@ void main() {
             <default></default>
           </div>
         ''',
-        changeDetection: ChangeDetectionStrategy.OnPush,
+        changeDetection: ChangeDetectionStrategy.onPush,
         directives: [DefaultComponent],
       )
       class TestComponent {}
     """, warnings: [
       allOf([
         contains('<default>'),
         contains(
-          '"DefaultComponent" doesn\'t use "ChangeDetectionStrategy.OnPush"',
+          '"DefaultComponent" doesn\'t use "ChangeDetectionStrategy.onPush"',
         ),
       ]),
     ]);
@@ -56,7 +56,7 @@ void main() {
               <default @skipOnPushValidation></default>
             </div>
           ''',
-          changeDetection: ChangeDetectionStrategy.OnPush,
+          changeDetection: ChangeDetectionStrategy.onPush,
           directives: [DefaultComponent],
         )
         class TestComponent {}
@@ -73,7 +73,7 @@ void main() {
             template: '''
               <div @skipOnPushValidation></div>
             ''',
-            changeDetection: ChangeDetectionStrategy.OnPush,
+            changeDetection: ChangeDetectionStrategy.onPush,
           )
           class TestComponent {}
         """, errors: [
@@ -91,7 +91,7 @@ void main() {
           @Component(
             selector: 'on-push',
             template: '',
-            changeDetection: ChangeDetectionStrategy.OnPush,
+            changeDetection: ChangeDetectionStrategy.onPush,
           )
           class OnPushComponent {}
 
@@ -101,15 +101,15 @@ void main() {
               <on-push @skipOnPushValidation></on-push>
             ''',
             directives: [OnPushComponent],
-            changeDetection: ChangeDetectionStrategy.OnPush,
+            changeDetection: ChangeDetectionStrategy.onPush,
           )
           class TestComponent {}
         """, errors: [
           allOf([
             contains('@skipOnPushValidation'),
             contains(
               'Can only be applied to a component using '
-              '"ChangeDetectionStrategy.Default"',
+              '"ChangeDetectionStrategy.checkAlways"',
             ),
           ]),
         ]);
@@ -138,7 +138,7 @@ void main() {
             contains('@skipOnPushValidation'),
             contains(
               'Can only be used in the template of a component using '
-              '"ChangeDetectionStrategy.OnPush"',
+              '"ChangeDetectionStrategy.onPush"',
             ),
           ]),
         ]);

diff --git a/_tests/test/core/change_detection/change_detection_link_test.dart b/_tests/test/core/change_detection/change_detection_link_test.dart
@@ -110,7 +110,7 @@ class DefaultComponent {
 @Component(
   selector: 'on-push-container',
   template: '<template #container></template>',
-  changeDetection: ChangeDetectionStrategy.OnPush,
+  changeDetection: ChangeDetectionStrategy.onPush,
 )
 class OnPushContainerComponent {
   @Input()
@@ -142,7 +142,7 @@ class LoadInOnPush {
     </on-push-container>
   ''',
   directives: [OnPushContainerComponent],
-  changeDetection: ChangeDetectionStrategy.OnPush,
+  changeDetection: ChangeDetectionStrategy.onPush,
 )
 class OnPushAncestorComponent {
   @Input()
@@ -170,7 +170,7 @@ class LoadInOnPushDescendant {
     </ng-container>
   ''',
   directives: [NgIf],
-  changeDetection: ChangeDetectionStrategy.OnPush,
+  changeDetection: ChangeDetectionStrategy.onPush,
 )
 class OnPushEmbeddedContainerComponent {
   OnPushEmbeddedContainerComponent(this._changeDetectorRef, this._ngZone);

diff --git a/_tests/test/core/change_detection/detached_lifecycle_test.dart b/_tests/test/core/change_detection/detached_lifecycle_test.dart
diff --git a/_tests/test/core/change_detection/mark_child_for_check_test.dart b/_tests/test/core/change_detection/mark_child_for_check_test.dart
@@ -109,7 +109,7 @@ void main() {
 @Component(
   selector: 'child',
   template: '{{value}}',
-  changeDetection: ChangeDetectionStrategy.OnPush,
+  changeDetection: ChangeDetectionStrategy.onPush,
 )
 class Child {
   var value = '';
@@ -245,7 +245,7 @@ abstract class HasValue {
   providers: [
     ExistingProvider(HasValue, ChildWithExistingProvider),
   ],
-  changeDetection: ChangeDetectionStrategy.OnPush,
+  changeDetection: ChangeDetectionStrategy.onPush,
 )
 class ChildWithExistingProvider implements HasValue {
   @override

diff --git a/_tests/test/core/change_detection/mark_for_check_test.dart b/_tests/test/core/change_detection/mark_for_check_test.dart
@@ -76,7 +76,7 @@ class UsesOnPushComponent {
   directives: [
     NgIf,
   ],
-  changeDetection: ChangeDetectionStrategy.OnPush,
+  changeDetection: ChangeDetectionStrategy.onPush,
 )
 class OnPushComponent {
   final ChangeDetectorRef _changeDetector;

diff --git a/_tests/test/core/change_detection/on_push_embedded_view_test.dart b/_tests/test/core/change_detection/on_push_embedded_view_test.dart
@@ -124,7 +124,7 @@ class TestComponent {
   template: '''
     <template #template>{{templateText}}</template>
   ''',
-  changeDetection: ChangeDetectionStrategy.OnPush,
+  changeDetection: ChangeDetectionStrategy.onPush,
   exportAs: 'templateProducer',
 )
 class TemplateProducerComponent implements OnInit {
@@ -149,7 +149,7 @@ class TemplateProducerComponent implements OnInit {
     <template #container></template>
     <div>{{text}}</div>
   ''',
-  changeDetection: ChangeDetectionStrategy.OnPush,
+  changeDetection: ChangeDetectionStrategy.onPush,
 )
 class TemplateConsumerComponent implements OnInit {
   @ViewChild('container', read: ViewContainerRef)

diff --git a/_tests/test/core/linker/component_loader_test.dart b/_tests/test/core/linker/component_loader_test.dart
@@ -317,7 +317,7 @@ class DynamicComp extends Lifecycles {
 @Component(
   selector: 'dynamic-comp',
   template: 'Dynamic{{input}}',
-  changeDetection: ChangeDetectionStrategy.OnPush,
+  changeDetection: ChangeDetectionStrategy.onPush,
 )
 class DynamicOnPushComp extends Lifecycles {
   DynamicOnPushComp(super.log);