Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not pass properties to page view tracking #12

Merged
merged 1 commit into from
Jul 21, 2016

Conversation

troex
Copy link
Contributor

@troex troex commented May 16, 2016

fixes #10

@troex troex changed the title do not pass properies to page view tracking do not pass properties to page view tracking May 16, 2016
@ProLoser
Copy link
Member

I think you'll encounter a lag of 1 route change if you do not pass the up-to-date information contained in $location

@troex
Copy link
Contributor Author

troex commented May 16, 2016

nope it's all good, I've tested with example, there is no delay

@troex
Copy link
Contributor Author

troex commented May 16, 2016

if you add console.log(properties); right before .page() call you will see:

screen shot 2016-05-17 at 00 25 58

there is absolutely no useful info for segment script, it won't parse angular private variables $$ anyhow

@ProLoser
Copy link
Member

@troex I have mixed feelings about this entire implementation but I can merge it however a new release needs to be cut. Do you want me to make you a collaborator on this repo?

@troex
Copy link
Contributor Author

troex commented May 16, 2016

I've looked at other implementations and there is nothing wrong or different in yours, maybe except angulartics.waitForVendorApi call is being used lately.

You can make me a collaborator but I don't promise I'll look after project, I could do some fixes or accept PRs and maybe respond to some issues if there would be any.

@timelf123 timelf123 merged commit 9addb03 into angulartics:master Jul 21, 2016
@timelf123
Copy link
Contributor

timelf123 commented Aug 25, 2016

#17 wants props back on the basis that the page tracking api takes custom props
https://github.com/angulartics/angulartics/blob/master/src/angulartics.js#L192-L196 do we need to strip the $$ from $location here?

https://segment.com/docs/sources/website/analytics.js/#page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$$ properties passed on pageviews
3 participants