Make __declspec(dllimport) optional (and off by default) #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added comment sums up the rationale, but to elaborate... the two big problems avoided by omitting it:
Of course, there may be edge cases where not prefixing with dllimport will cause undesired behavior, or generate a more substantial relocation thunk with a significant performance impact. Those that find themselves dealing with such cases can simply define EPOXY_USE_DLLIMPORT where necessary.
This is a pretty good explanation of what __declspec(dllimport) actually does: http://blogs.msdn.com/b/russellk/archive/2005/03/20/399465.aspx?wa=wsignin1.0