New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for non-zero exit status #5
Conversation
Could you update
|
@anhskohbo Absolutely. |
@anhskohbo Typically interactive modes are something you opt-in to rather than opt-out of, but I've done what you've asked in ae98753. I also extended this concept into the theme selection process by defaulting to the current active theme if no |
Nice work! Thanks for this pull-request! |
@@ -178,7 +188,7 @@ private function choices_theme() { | |||
$themes[ $id ] = $theme->get( 'Name' ); | |||
} | |||
|
|||
return cli\menu( $themes, wp_get_theme()->template, 'Choose a theme' ); | |||
return cli\menu( $themes, get_stylesheet(), 'Choose a theme' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anhskohbo Not sure if you knew this, but the default name was set to template
which meant if the current theme was a child theme the name of its parent theme would be displayed. This did not seem right to me so I changed it to use the stylesheet
.
Implements #4
0
when all tests passREQUIRED
andWARNING
errors as the exit status codeRemove interactive prompt for Theme Check plugin dependency that blocks automated workflows--interactive
flag that istrue
by default but can be negated with--no-interactive
1
when the Theme Check plugin dependency is not met