Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

This is not a issue. More of a question of understanding. #137

Closed
KainesLaw opened this issue Jul 7, 2021 · 5 comments
Closed

This is not a issue. More of a question of understanding. #137

KainesLaw opened this issue Jul 7, 2021 · 5 comments

Comments

@KainesLaw
Copy link

So when I change a command setting to enabled: true to enabled: false, I still can use the command. Or do I bypass it since I am the owner?

  1. What does GuildOnly mean?

Sorry for the trouble. I am new to having all these new features in command handlers.

@Chicken
Copy link

Chicken commented Jul 7, 2021

Seems like enabled is broken (not utilised at all by the command handler?). GuildOnly means that the command can only be used in servers and not in DMs.

@KainesLaw
Copy link
Author

Seems like enabled is broken (not utilised at all by the command handler?). GuildOnly means that the command can only be used in servers and not in DMs.

Ah that's a shame that it's broken.

@YorkAARGH
Copy link
Member

Unfortunately it's a relic of an old version of guidebot, we intended to implement this feature but we didn't know HOW to do it, it's remained in the code for the hopeful time we do add the functionality.

@YorkAARGH YorkAARGH reopened this Jul 9, 2021
@YorkAARGH
Copy link
Member

YorkAARGH commented Jul 9, 2021

Hey, I had to reopen this issue because I thought we didn't implement this yet. I looked through the code to see if we had or not and yeah we did actually implement this feature, and for all intents and purposes it fully works as showed here in this screenshot.

The way the code is currently written, not even owners of the bot should be able to bypass this as shown in the code here, and in the screenshot above I am listed as the bot owner and it still gave me the "disabled" message.

If you need support for this issue, you can drop by the server (link is at the top of the org page) for a more speedy support than here @KainesLaw.

Bah... stupid me... I shouldn't read/code first thing in the morning... disregard what I said LOL complete misunderstanding on my behalf... I'll certainly be looking into this a.s.a.p. now that I understand the issue at hand.

YorkAARGH added a commit that referenced this issue Jul 9, 2021
@YorkAARGH
Copy link
Member

This has been fixed in the v13 update, which can be backported to v12.

YorkAARGH added a commit that referenced this issue Aug 8, 2021
* Initial update to v13

Updated everything

* Update guildCreate.js

updated from `user.id` to `ownerId`

* V13 Setup.JS fix + reboot.JS command update (#139)

* Adding partials to update baseConfig

* Adding logical "restart" alias

* Updated commands.

Updated all the commands that output codeblocks, used the new formatters.

* Thread support

Added a single line of code to make Guidebot auto-join any threads created, useful for moderation bots.

* Guidebot will now ignore disabled commands

Fix #137

* Updating invite link

* Removed unused dep

* Slash Commands (#143)

* Slash Commands

Added slash command support to the original (main) version of guidebot.

Updated discord.js to version 13.0.1, updated the throw in the index to require version 16 of nodejs.

Brought both versions of guidebot to the same functional level.

* Fixed a small mistake

The setup placed the partial array inside an array causing an error.

* Minor update

Updated the readme to be concise with the other version.
Updated the setup script, removed the deprecated ownerId field.

* Consistency fix

The prefix for the bot in two files were different compared to the one in the set up script. Fixed for consistency.

* The real quick fix

Actually fixed the damn thing this time.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants