Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows port #8

Closed
anishathalye opened this issue Jul 31, 2016 · 8 comments
Closed

Windows port #8

anishathalye opened this issue Jul 31, 2016 · 8 comments

Comments

@anishathalye
Copy link
Owner

A couple people have asked about a Windows port, so here's an issue where that can be discussed

@oliverguhr
Copy link

Looks like there is a Windows API function to set the brightness. MSDN SetMonitorBrightness

@anishathalye
Copy link
Owner Author

I don't have any Windows development experience, so it would be great if there's someone else who wants to build a Windows version.

(it shouldn't be too complicated, you can probably copy-paste most of the core logic from the Mac OS code cause it's basically C code)

@Braunson
Copy link

Braunson commented Aug 1, 2016

I wonder if this can be done with the Electron framework.

Edit; Yeah I get it, Electron is a hog and not ideal for this.

@chris-morgan
Copy link

chris-morgan commented Aug 1, 2016

@Braunson … and watch resource usage skyrocket. This is the sort of thing that should use near enough to no memory—I’m guessing it borrows a screen buffer rather than even needing to allocate enough space for that, so we’re probably talking hundreds of kilobytes only, not dozens or scores of megabytes as it would do with Electron. CPU usage would also be inordinate if you were implementing it via Electron.

There’s a place for things like Electron. This is definitely not it.

@anishathalye anishathalye mentioned this issue Aug 3, 2016
@AlaaAlShammaa
Copy link

AlaaAlShammaa commented Aug 5, 2016

Here's a windows version of the app: https://github.com/AlaaAlShammaa/Luminance

@anishathalye
Copy link
Owner Author

@AlaaAlShammaa added it to the list of related projects

@AlaaAlShammaa
Copy link

@anishathalye Thank you very much 👍

@anishathalye
Copy link
Owner Author

Closing this issue due to inactivity. If there are any other ports of Lumen that work on Windows, we should add them to the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants