Windows port #8

Open
anishathalye opened this Issue Jul 31, 2016 · 7 comments

Comments

Projects
None yet
5 participants
Owner

anishathalye commented Jul 31, 2016

A couple people have asked about a Windows port, so here's an issue where that can be discussed

Looks like there is a Windows API function to set the brightness. MSDN SetMonitorBrightness

Owner

anishathalye commented Aug 1, 2016

I don't have any Windows development experience, so it would be great if there's someone else who wants to build a Windows version.

(it shouldn't be too complicated, you can probably copy-paste most of the core logic from the Mac OS code cause it's basically C code)

Braunson commented Aug 1, 2016 edited

I wonder if this can be done with the Electron framework.

Edit; Yeah I get it, Electron is a hog and not ideal for this.

chris-morgan commented Aug 1, 2016 edited

@Braunson … and watch resource usage skyrocket. This is the sort of thing that should use near enough to no memory—I’m guessing it borrows a screen buffer rather than even needing to allocate enough space for that, so we’re probably talking hundreds of kilobytes only, not dozens or scores of megabytes as it would do with Electron. CPU usage would also be inordinate if you were implementing it via Electron.

There’s a place for things like Electron. This is definitely not it.

anishathalye referenced this issue Aug 3, 2016

Open

Linux port #7

AlaaAlShammaa commented Aug 5, 2016 edited

Here's a windows version of the app: https://github.com/AlaaAlShammaa/Luminance

Owner

anishathalye commented Aug 5, 2016

@AlaaAlShammaa added it to the list of related projects

@anishathalye Thank you very much 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment