-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: User Login API issue#47 #60
Feat: User Login API issue#47 #60
Conversation
Update @anitab-org/bridgeintech-maintainers . I've just created Login API. Can you please review this PR. @ramitsawhney27 , do you want the test cases to be done on a separate PR or just in this one? I'm thinking of waiting for the Register API test cases PR to be approved and add Login API on top of that code base, so will do a separate PR from this one. What do you think? |
Update @anitab-org/bridgeintech-maintainers . I've just pushed latest code change to fix message display connection error response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtreacy002 I added comments according to our 1:1 today, where we discussed you can remove the Refresh API related code, as this is not a priority for MVP.
f074711
to
a9ef471
Compare
1d6a64d
to
ff18b92
Compare
|
||
def http_bad_request_checker(result): | ||
|
||
if result[0] == f"{messages.USERNAME_FIELD_IS_MISSING}": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this change now? should be indexed using the named tuple?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, It is now (on PR #65), already using namedtuple. This Login PR #60 was made before that namedtuple PR. I don't think I need to change in this PR since it'll be overwritten by PR #65 changes if that one also got approved after this.
screenshot from namedtuple ms_api_utils.py
The commit history showing sequence of changes
ff18b92
to
6a4f60c
Compare
@anitab-org/bridgeintech-maintainers . Any progress on this PR review? If there's no other changes required, can you please approve this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested User Login API here with no errors
@ramitsawhney27 as you have reviewed tthis PR and verbally approves it in BIT weekly meeting last week, can you please give the formal approval so it can be merged? Thanks |
Description
Added Login User API
Fixes #47
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Try to login a user
Gif file: https://media.giphy.com/media/L329CK5dENhpM68PVN/giphy.gif
Checklist:
Code/Quality Assurance Only