Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Create Login API #47

Closed
ramitsawhney27 opened this issue Jun 7, 2020 · 1 comment · Fixed by #60
Closed

Development: Create Login API #47

ramitsawhney27 opened this issue Jun 7, 2020 · 1 comment · Fixed by #60
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program. Type: Enhancement New feature or request.

Comments

@ramitsawhney27
Copy link

ramitsawhney27 commented Jun 7, 2020

Description
As a student, I need to have the ability to login to BIT. For this the API on the backend should be available.
Mocks
NA

Acceptance Criteria
Create an API for user login for the BIT backend. The API would take a username/password combination as input and return a response code based on the validity of the data in the database. Majorly, 2 outcomes are possible: Successful (200 OK), or Unsuccessful (40x) (x represents one of the error codes like 400, 403, etc.)

Alternatives for testing the API: CuRL/Python requests

Update [Required]
Flask POST request for user login
Takes user attributes as a json (eventually this will be sent through the UI)
Response handling: 200 (Successful Process), 401 (unauthorized), 403 (forbidden), 400 (bad request), 500 (internal server error)
Test the API using Postman (or any alternative)
Enhancement to Update [Optional]
Definition of Done
All of the required items are completed.
Approval by 2 mentors.

@ramitsawhney27 ramitsawhney27 added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program. Type: Enhancement New feature or request. labels Jun 7, 2020
@mtreacy002
Copy link
Member

@ramitsawhney27 . Just want to confirm.
For success Login response, we want it to be 200 OK not 201 Created, as per discussed in the Proposal Review document. Am I right?

Screen Shot 2020-06-19 at 9 30 13 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program. Type: Enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants