Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue8 register ui - new pr #18

Merged

Conversation

mtreacy002
Copy link
Member

@mtreacy002 mtreacy002 commented Jun 14, 2020

Description

This PR is to provide Register UI and backend consumption.

Fixes #8 and replaces PR #15

Type of Change:

  • Code
  • User Interface

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

By creating new user as well as trying to register with existing user's data

Steps to test:

  • run the following servers locally:
    • BIT backend server - must use port 5000 (stated as allowed CORS origin url inside MS backend code base).
    • MS backend server - I recommend using port 4000
    • BIT React server - will by default run on port 3000 (stated as allowed CORS origin url inside the BIT backend code base)

Note: I recommend tester/reviewer to create a separate branch on MS backend to run MS server as there a few lines of code need to be added inside the MS backend run.py which is specific to BIT only (in the future I will open an issue on MS side to accommodate this). Please refer to run.py inside code changes for BIT PR#52 and update your pip dependencies as per that PR additional notes.

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings

@mtreacy002 mtreacy002 requested a review from a team June 14, 2020 10:20
@mtreacy002 mtreacy002 self-assigned this Jun 14, 2020
@mtreacy002 mtreacy002 added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. Program: GSOC Related to work completed during the Google Summer of Code Program. labels Jun 14, 2020
@mtreacy002 mtreacy002 added this to the GSoC: Coding Phase I milestone Jun 14, 2020
@foongminwong
Copy link

The changes made in this PR were tested locally. Following are the results:

  1. All possible responses are tested below:

    • Test new Register Form
      Screenshot/gif/url:
      test-register-form-red-warnings

      Expected Result: Red warnings show up when (1) fields are left blank, (2) password too short, (3) confirm password doesn't match, (4) invalid email address when email is missing @ or .com, etc. (5) username too short or with invalid characters

      Actual Result: Same as expected.

    • Register a user using new Register Form
      Screenshot/gif/url:

    test-bit-pr-18

    Expected Result: User registration is processed successfully. If the user wants to register using same account information, it will show A user with that username already exists.

    Actual Result: Same as expected.

  2. Additional comments:

    • Great job @mtreacy002 !! The Register UI functionality works on my end
    • Based on your previous comment, the register form temporarily won't have the fields/functionaly for the Confirm Password, Show Password, and the radio buttons for (Mentor, Mentee, Both).
  3. OS Version: Windows 10

@mtreacy002
Copy link
Member Author

Thank you @foongminwong for you feedback... Loving how you test the PR as you review 😉 😍

.gitignore Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@meenakshi-dhanani meenakshi-dhanani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foongminwong reviewed the functionality, seems fine. Reviewed the code. Works as expected

@meenakshi-dhanani
Copy link
Contributor

@foongminwong if all looks good, can you approve?

@meenakshi-dhanani meenakshi-dhanani merged commit b5bf859 into anitab-org:develop Jun 15, 2020
@mtreacy002 mtreacy002 deleted the issue8-register-ui-new branch June 27, 2020 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. Program: GSOC Related to work completed during the Google Summer of Code Program.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register a user
3 participants