-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Idea] Create recover password option on Sign In Screen #59
Comments
For this issue has the backend api been updated? @isabelcosta |
@mohak1283 no it isn't. It isn't done nor planned. So it needs discussion and someone willing to work on this :) |
@isabelcosta can I work on it? |
Sure @shaliniv16 but this has to be implemented on the backend first. And needs discussion on its implementation. Do you want to work on it on the backend? |
@isabelcosta if you don't mind can I start working on this feature as since we are left with almost one month. so, can I start working on this as I would definitely be able to complete this feature so, can I work upon it ? |
@isabelcosta @mayburgos I would definitely work on both backend part for its working and frontend for button part as it will then be an as good start for me to understand the backend code. So I am willing to work upon it :) |
Hi, I am still working on this issue !! [just a reminder] :) |
hi, i am still working on this :) |
@robotjellyzone thank you for the updates. Let me know if you need any help :) |
Hi, @isabelcosta I will definitely ask if I need your help. Actually I am a beginner in backend kind of things, so, I am just figuring out what all changes I need to do in the backend and in the frontend. Since there are so many files used in backend [all relating to each other] so, I am taking my time and modifying or adding code one by one in each file .... This actually requires adding code for backend API and then for the front end model. Right now, I am just taking a lot of time to go through and learn about the working of each and every file and modifying it accordingly. :) |
Hi @isabelcosta @annabauza till now I am done with creating the backend api for this recovery feature, and from now on I will be moving on to creating its frontend feature, but I have a little confusion that should a create a separate issue for adding PR for my backend api or should I just continue with adding PR of frontend & backend both same in one PR for this same issue? |
Hi @isabelcosta @annabauza i have one more confusion since i am sending a reset link in the email for reset password, so where should i redirect that link to... as right now there is not web version of this app, so should i direct that link to a new web form [which i have to create] or should i direct it to the screen of the app where user can enter a new password, [but for this i need your help] ? |
Till now i have added the backend api for forgot password [to send reset link to the email] and for reset password [to make new password] as shown in the images below :
Sorry @isabelcosta it took me too long to create these as since i said earlier, i am a beginner in backend stuffs .so, first i did some online tutorials then i started reading all the methods used in the various no. of files that were there in the bckend code. Then after that , after making myself comfortable with flask , i started writing code in it ...So, that's why it took soo long. |
Also, @isabelcosta can i remove that slack part/section from frontend & backend as well as i think since slack is no more used then it will be fine to remove it from every section of app as well .. |
I really like your detailed explanation on how you designed and implemented this feature 👏 , I think this is ready for you to submit PR? Is it? I think I told you in an AMA (not sure), that you could create the web page to reset the password 🤔 I have no problem with you taking time, you were learning, that is exciting 😄 What is the slack part you are mentioning? What is this related with? @robotjellyzone If this is not related with the forget password, then please create the issue for it, so that wee can approve and then assign :) |
Hi @isabelcosta sorry, i am just stuck unexpectedly in my university's work as they gave a quick deadline to submit project report and give presentations and other stuffs but i promise will soon update you regarding the PR ... Sorry for late reply as well 😓 and yeah, i will create a different issue as if you remember in your AMA i asked that whether the SLACK is still available but then you said NO so, that's why i thought if SLACK is not available any more then we should remove asking slack ids on our app as well in the profile section as other part as well ..... Also, to send my PR i need to create a new issue at backend side as well so, that i can send PR to their itself ... |
Hi @isabelcosta sorry for late reply , now i am free [from all those project work of university] I am sending PR at the backend side for this issue by referencing it rather then creating a new issue on backend as it will take your much time ... Also, i am not going to add that html form to update password i thought i would just allow user to use swagger ui to reset its password ... But later on when i will be adding code for front end part will then add that form or will create a screen in the app itself that will allow user to change password using that screen.... |
Closing since it's a duplicate of #780 |
Is your feature request related to a problem?
The mobile app does not have a forgot password option.
Describe the solution you'd like
Create an option to recover the password, such as a text in the login screen, asking if the user does not remember the password.
Describe alternatives you've considered
Backend search for email/username and auto-send for username
^username would be an automated reminder of username
^password we need a process to reset
Additional context
N/A
The text was updated successfully, but these errors were encountered: