Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Refresh endPoint of the Api to Refresh AuthToken #1023

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

epicadk
Copy link
Member

@epicadk epicadk commented Oct 25, 2020

Description

Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.

Use refresh endpoint to refresh users auth token
Fixes #1022

Type of Change:

Delete irrelevant options.

  • Code

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged
  • I have written Kotlin Docs whenever is applicable

Code/Quality Assurance Only

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@epicadk epicadk marked this pull request as ready for review October 25, 2020 14:43
@epicadk
Copy link
Member Author

epicadk commented Oct 25, 2020

@isabelcosta will I also have to add tests?

anna4j
anna4j previously approved these changes Oct 27, 2020
@anna4j anna4j added the Status: Needs Review PR needs an additional review or a maintainer's review. label Oct 27, 2020
@devkapilbansal devkapilbansal added this to the 1st MVP milestone May 7, 2021
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epicadk please resolve the merge conflicts

@vj-codes vj-codes added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use refresh endpoint of the api.
4 participants