feat: Migrate SharedPreferences to DataStore #1178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vj-codes
added
the
Status: Needs Review
epicadk
suggested changes
Nov 24, 2021
| } | ||
|
|
||
| implementation(Dependencies.datastore) | ||
| } |
There was a problem hiding this comment.
add a blank line or just run spotless using gradlew sA
| @@ -28,6 +28,7 @@ object Versions { | |||
| const val appCompat = "1.0.2" | |||
| const val circleImageView = "3.0.1" | |||
| const val fragmentKtx = "1.2.5" | |||
| const val datastore = "1.0.0-alpha02" | |||
|
|
||
| private val dataStorePreferences = context.createDataStore(APPLICATION_PREFERENCE) |
|
@epicadk I am getting build error. Can you please help? I just update the DataStore version but it is showing this error The minCompileSdk (30) specified in a
dependency's AAR metadata (META-INF/com/android/build/gradle/aar-metadata.properties)
is greater than this module's compileSdkVersion (android-28).
Dependency: androidx.datastore:datastore-preferences:1.0.0.
AAR metadata file: W:\Android Gradle\caches\transforms-3\3298931b4e39777ba18ae456fda6204c\transformed\jetified-datastore-preferences-1.0.0\META-INF\com\android\build\gradle\aar-metadata.properties.
if I update the compileSDKVersion then it is showing random errors. |
bump compile sdk to 30 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1177
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
I make the changes and try running this app on my device, but I got a 401 Authentication error on 1st run only. After that app runs fine as it should be.
screen.mp4
Checklist:
Code/Quality Assurance Only