Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Registration UI with options to select availability to mentor or be a mentee #69

Closed
wants to merge 1 commit into from

Conversation

nicoledacey
Copy link

@nicoledacey nicoledacey commented Sep 27, 2018

Description

"Implemented a selection of mentor or mentee option during registration"

Fixes #64

Type of Change:

Delete irrelevant options.

  • Changed the constraints between widgets and layouts to allow new components to be placed.
    -Added new checkboxes that allowed the user to decide their role.

Code/Quality Assurance Only
-Found errors when selecting the relation tab.

  • Keyboard not hiding when clicking white space
  • Text label not clearing when clicking the cancel button.

How Has This Been Tested?

The UI change is not visible nor is connected to the backend.

Code/Quality Assurance Only

  • My changes generate no new warnings

@m-murad
Copy link
Contributor

m-murad commented Sep 28, 2018

@nicoledacey This needs to be implemented in the backend first.

@isabelcosta isabelcosta changed the title Implimented a selection of mentor or mentee option during registration Improve Registration UI with options to select availability to mentor or be a mentee Oct 1, 2018
@isabelcosta
Copy link
Member

@m-murad we knew about that, we still wanted to try the UI and see how it would be, we can put this on hold while the backend part is not done. I'll create an issue for that on the backend side.

Backend issue: anitab-org/mentorship-backend#144

@isabelcosta isabelcosta added DO NOT MERGE Program: GHC OSD Related to work completed during the Grace Hopper Celebration's Open Source Day. labels Oct 1, 2018
@isabelcosta
Copy link
Member

@m-murad this functionality is already implemented on the backend (through anitab-org/mentorship-backend#146), but this PR needs that part of integrating with the Backend.

If @nicoledacey does not respond or can't work on this, no problem! We can close this PR, and make the issue available to be worked on by another contributor (linking to this PR with some work already done).

Anyways @nicoledacey thank you for reporting this nice feature and fixing the ConstraintLayout :)

@isabelcosta
Copy link
Member

Closing this to be worked by another contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: GHC OSD Related to work completed during the Grace Hopper Celebration's Open Source Day. Type: Enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants