fix: Bottom Navigation Tab Reselected Bug

[DhaneshShetty]

Description

After the fix, Fragment is not replaced on reselecting the current fragment. This is done by adding onNavigationItemReselectedListener.

Fixes #724

Type of Change:

Delete irrelevant options.

• User Interface

Code/Quality Assurance Only

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested Locally on Redmi 8A
Android 9

Checklist:

Delete irrelevant options.

• My PR follows the style guidelines of this project
• I have performed a self-review of my own code or materials

Code/Quality Assurance Only

• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[MariamKotob]

LGTM& changes work really fine.
Thanks for your contribution.

[rahulshah456]

LGTM

[faznan3nazer]

When i click on the already active bottom navigation item then the fragment i think it is still changing..don't know whether it is the problem with my internet or system... @foongminwong , @HaripriyaB , @sakshivij can one of you test this, just to make sure..

[foongminwong]

When i click on the already active bottom navigation item then the fragment i think it is still changing..don't know whether it is the problem with my internet or system... @foongminwong , @HaripriyaB , @sakshivij can one of you test this, just to make sure..

Sorry for the late reply @faznan3nazer , let me check right now..

[foongminwong]

The changes made in this PR were tested locally. Following are the results:

1. Code review - Done

2. All possible responses were tested as below:

   • Before PR725
     Screenshot/gif/url:

     

   Expected Result: The Bottom Navigation Tab Reselected Bug exists.
   Actual Result: Same as expected.

   • AFter PR 725
     Screenshot/gif/url:

     

   Expected Result: The Bottom Navigation Tab Reselected is eliminated.
   Actual Result: Same as expected.

3. Additional testcases covered: N/A

4. Additional Comments:

• @faznan3nazer I am able to see the changes when tested locally. It also took me awhile to refresh the app since my laptop is slow too 😆
• Good job @DhaneshShetty !!

5. Status of PR Changed to: Ready to Merge.

6. Android Version: 9.0, Device: Android Emulator Pixel API 28

[foongminwong]

@isabelcosta feel free to approve and merge this pr when you have time, it's reviewed and tested (see above ☝)

[isabelcosta]

Looks good! Thank you for this amazing contribution @DhaneshShetty 🎉

[isabelcosta]

Thank you so much for testing this @foongminwong 👏