Update the user with existing name and username.

[faznan3nazer]

When you are updating the user with existing name and username, you are getting an error message "A user with that username already exists."
To Reproduce

Steps to reproduce the behavior:

Current username: zxcvbnm
Updating username to: zxcvbnm,
Current name: zxcvbnm
Updating name to: zxcvbnm,

1. Go to 'User-update user profile'.
2. Provide the access token.
3. .{
   "name": "zxcvbnm",
   "username": "zxcvbnm",
   "bio": "string",
   "location": "string",
   "occupation": "string",
   "organization": "string",
   "slack_username": "string",
   "social_media_links": "string",
   "skills": "string",
   "interests": "string",
   "resume_url": "string",
   "photo_url": "string",
   "need_mentoring": true,
   "available_to_mentor": true
   }
4. Click on 'Execute'.
5. Scroll down to 'Responses'.

Expected behavior
It should either be successfully updated message or a message like "no fields have been updated". Also the error message being shown now is not listed under responses.

Desktop (please complete the following information):

• OS: Windows 10
• Browser chrome

[gaurivn]

I added the Status: On Hold since I thought of including this issue for the upcoming Open Source Hack.

[alapan-sau]

I would like to work on this issue for OSH.

[gaurivn]

Hi @alapan-sau, this issue will be made available once Open Source Hack starts on September 1st, 2020. Till then you can set up the development environment for and familiarise yourself with mentorship-backend. If you've any doubts feel free to ask them on Zulip.

[alapan-sau]

As OSH is open today, May I work on this issue?

[gaurivn]

As OSH is open today, May I work on this issue?

Hi @alapan-sau, you've already been assigned issue #746, once you're done with sending a PR for the same, you can work on available issues.

[faznan3nazer]

I would like to work on this issue... Can you please assign this to me for Open-Source Hack?

[gaurivn]

I would like to work on this issue... Can you please assign this to me for Open-Source Hack?

Sure @faznan3nazer, here you go

[vj-codes]

@faznan3nazer making it available as you are already assigned #606

[pallavisavant]

can i work on this issue ...Thanks.

[vj-codes]

Assigning you @pallavisavant
Happy coding!

[pallavisavant]

@vj-codes I am facing one issue while reproducing this....we get the access token by giving username and password in login section rgt,and after that we are supposed to use this token for updating ...it shows invalid token wherever i am using it.Can anyone help ..Thanks.

[vj-codes]

Assigning you @epicadk
Happy coding!

[epicadk]

Should I also handle race conditions? @isabelcosta @faznan3nazer

[isabelcosta]

@epicadk which race conditions?

[epicadk]

@epicadk which race conditions?

Currently , we first check if the username is available or not and then proceed to updating it . However this isn't how it should be implemented because what happens when two users try to register with the same username and almost the same time? It would lead to an unexpected error. So we shouldn't query the database to check if the username if available or not but rather just update the username and handle the exception if a user with that username already exists.

[epicadk]

@isabelcosta I can't seem to find the link to the resource where I read about this but I can try to explain here. So consider 2 users user1 and user2. Suppose both of them want to ( in this case) change their existing username to the new same username. So what'll happen is first user1's request will check if the username is already taken and it will find that the username does not exist in the database, at the same time user2's request can also query the database to check if the username exists and since user1's data hasn't been updated yet user2 will also find that the username is available. Consider User1's data is now updated however when user2 attempts to update their data an exception will be thrown and the app will crash if this is not handled.

[epicadk]

I'm sorry that probably doesn't explain it well enough maybe I can try in the mentorship open session.

[isabelcosta]

No problem @epicadk we'll discuss in the meeting :)

[epicadk]

Actually this is working just fine. The documentation is not clear enough maybe you only have to send the data you want to change. So say you only want to change location from Perth to Sydney then you would only send
{"location" : "Sydney"} and nothing else. Do we want to change this behavior and expect the user to send all fields or should I keep it like this?

[epicadk]

Un-assigning myself as the required behavior needs to be discussed before changes are made. The endpoint does what is claims to do. If we do expect all the user data to be present then the documentation needs to be changed as well. Adding this to the mentorship system agenda. cc @isabelcosta

[isabelcosta]

I think remember this being the issue of PUT vs PATCH 🤔 just putting here so I don't forget later

[diananova]

Can I work on this? @isabelcosta

[hirshrm]

Hi, is anyone working on this? Could I be assigned to work on it if not? @vj-codes

[vj-codes]

Assigning you @hirshrm
Happy coding!