-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Issue#62 update user api endpoint #74
Feat: Issue#62 update user api endpoint #74
Conversation
Note @anitab-org/bridgeintech-maintainers . The probleem is BIT schema uses Organization table link to MS User table as FK. So MS User model should not have I'll try to rename |
e8b9165
to
4df201a
Compare
Update @anitab-org/bridgeintech-maintainers .
This PR is now complete and ready to be reviewed. 🔊 Note for reviewer: If you'd like to test this Update user personal details manually, you need to run MS server from |
8ee18a7
to
c50a12b
Compare
c50a12b
to
2de1a87
Compare
@isabelcosta and @anitab-org/bridgeintech-maintainers . The renaming User table |
The gif was too large to upload, this PR was tested successfully. https://giphy.com/gifs/U1mItXgfG1MEKsuYsk (a little blurry) |
Description
Create PUT /user/personal_details api endpoint and test cases
Fixes #73 as sub-issue of #62
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
ms-bitschema-backend-server
, you must create a new user first, login then you can update the user profile.User profile before update (called using GET/user/personal_details):
![Screen Shot 2020-07-09 at 9 04 40 pm](https://user-images.githubusercontent.com/29667122/87034305-fac74600-c22a-11ea-9321-937b801f4d59.png)
NOTE: with the current bug reported on issue #596 MS backend, I don't have any other option but to update ONLY the username.
Successful update message (on PUT/user/personal_details):
![Screen Shot 2020-07-09 at 9 05 11 pm](https://user-images.githubusercontent.com/29667122/87034042-8e4c4700-c22a-11ea-87de-0a6538aed994.png)
Check to make sure user profile gets updated (by calling GET/user/personal_details):
![Screen Shot 2020-07-09 at 9 05 31 pm](https://user-images.githubusercontent.com/29667122/87034252-e5521c00-c22a-11ea-8b6d-a218b1ba5ce1.png)
Checklist:
Code/Quality Assurance Only