Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

MembersPage: add search feature #38

Closed
bartekpacia opened this issue May 3, 2020 · 19 comments · Fixed by #114
Closed

MembersPage: add search feature #38

bartekpacia opened this issue May 3, 2020 · 19 comments · Fixed by #114
Assignees
Labels
Type: Enhancement New feature or request.

Comments

@bartekpacia
Copy link
Contributor

bartekpacia commented May 3, 2020

Is your feature request related to a problem?
Currently the searching functionality in the MembersPage doesn't work.

Describe the solution you'd like
Adding the search feature like in the Android app.

A final solution should preferably use BLoC pattern (like the rest of the app). I'm not quite sure how it would look like, so the person who will be doing it: implement it so that it will just work and we will iterate on it & improve.

@bartekpacia bartekpacia added Type: Enhancement New feature or request. Help Wanted Extra attention is needed. Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels May 3, 2020
@techno-disaster techno-disaster added Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. and removed Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels May 22, 2020
@techno-disaster
Copy link
Contributor

Status: on hold until pagination

@techno-disaster techno-disaster added Status: Available Issue was approved and available to claim or abandoned for over 3 days. and removed Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. labels May 27, 2020
@techno-disaster
Copy link
Contributor

@anitab-org/mentorship-flutter-maintainers Can i work on this? 😉 :)

@bartekpacia
Copy link
Contributor Author

good luck:D

@techno-disaster techno-disaster removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label May 27, 2020
@techno-disaster
Copy link
Contributor

Ok lol, i have no idea how to implement this, do we plan to use the /users/{userId} endpoint? or just load all the users first and check for names in the list?

@isabelcosta
Copy link
Member

@techno-disaster You can use search query parameter.

Server: https://mentorship-backend-temp.herokuapp.com/

image

@techno-disaster
Copy link
Contributor

@techno-disaster You can use search query parameter.

Server: https://mentorship-backend-temp.herokuapp.com/

image

@isabelcosta I tried entering the name in the search query field, but kept getting a empty list.I also tried entering the userId in the search field. What am i supposed to put in it?

@bartekpacia
Copy link
Contributor Author

Have you tried doing it using sth like Postman just to exclude that it's API pitfall?

@techno-disaster
Copy link
Contributor

Have you tried doing it using sth like Postman just to exclude that it's API pitfall?

i tried curl from my command line, I really don't think its a pitfall. The search parameter should have better documentation imo

@techno-disaster
Copy link
Contributor

Were you able go get any output?

@bartekpacia
Copy link
Contributor Author

I cannot set up backend locally, getting really crazy errors that some native libraries can't be compiled.
Maybe you should create an issue for this in the backend repo?

@techno-disaster
Copy link
Contributor

I cannot set up backend locally, getting really crazy errors that some native libraries can't be compiled.
Maybe you should create an issue for this in the backend repo?

exactly same issue here, although i thought that was some issue with my laptop specifically.

@isabelcosta
Copy link
Member

I cannot set up backend locally, getting really crazy errors that some native libraries can't be compiled.

🤯

Maybe you should create an issue for this in the backend repo?

It's open source 🤹‍♀️ @techno-disaster what should be better in the documentation in your own opinion? Do create an issue if you really feel there is something missing.
@bartekpacia what are the crazy errors?

If we want to get this flutter app working with the backend we have to be comfortable working with the backend and communicating issues we have with it. Otherwise, you will be dependent on other people to deal with backend. I or anyone who already ran the backend can help you both. Have you asked on zulip? (I am falling behind on Zulip messages to be honest)

@techno-disaster
Copy link
Contributor

techno-disaster commented May 30, 2020

I cannot set up backend locally, getting really crazy errors that some native libraries can't be compiled.

Maybe you should create an issue for this in the backend repo?

It's open source @techno-disaster what should be better in the documentation in your own opinion? Do create an issue if you really feel there is something missing.
@bartekpacia what are the crazy errors?

If we want to get this flutter app working with the backend we have to be comfortable working with the backend and communicating issues we have with it. Otherwise, you will be dependent on other people to deal with backend. I or anyone who already ran the backend can help you both. Have you asked on zulip? (I am falling behind on Zulip messages to be honest)

@isabelcosta I would like to know what exactly do we enter in the search field. An example in the swagger UI would be helpful. Also I am trying to get the backend ready by changing some versions, will ask on zulip if i get stuck again

@isabelcosta
Copy link
Member

@techno-disaster its just a string, for example if you want to find a user called "Isabel" the query could be "search": "isa".

I answered on Zulip as well. Could you create an issue on backend to improve documentation about search query parameter?

@techno-disaster
Copy link
Contributor

@isabelcosta tried it, still getting an empty list. can you upload a screenshot with what exactly we have to put in the search box?

image

@isabelcosta
Copy link
Member

What is the "%22" in the search parameter @techno-disaster ?
Remove the " quotes, that should not be there. When removing the quotes that will work

@techno-disaster
Copy link
Contributor

What is the "%22" in the search parameter @techno-disaster ?
Remove the " quotes, that should not be there. When removing the quotes that will work

strangely searching isa gives me a output but tech does not. does the search need a page too? like does the search only search on the particular page or whole database? Can you try searching tech

@techno-disaster
Copy link
Contributor

This is what I mean @isabelcosta ,searching isa gives me a result but urs or tech only gives me an empty list

urs
image

isa
image

@techno-disaster techno-disaster added the Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. label Jun 17, 2020
@techno-disaster
Copy link
Contributor

Status on hold until fixed on the backend.
Issue : #644

@techno-disaster techno-disaster removed Help Wanted Extra attention is needed. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. labels Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants