Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

feat: search members #114

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Conversation

techno-disaster
Copy link
Contributor

@techno-disaster techno-disaster commented Jul 22, 2020

Description

Let other users search mentors and mentees using the search functionality :)

Fixes #38

Flutter Channel:

  • I have used the Flutter Beta channel on my local machine

Type of Change:

Delete irrelevant options.

  • User Interface

How Has This Been Tested?

Physical device. Adding video below
ezgif com-video-to-gif

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

@techno-disaster techno-disaster added Type: Enhancement New feature or request. Category: User Interface Improvements or additions to design. labels Jul 22, 2020
@techno-disaster
Copy link
Contributor Author

@anitab-org/qa-team can someone give this a quick test?

Copy link
Contributor

@HaripriyaB HaripriyaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@Akanksha1212
Copy link
Contributor

Great work! @techno-disaster

@Akanksha1212 Akanksha1212 added Status: Needs Review PR needs an additional review or a maintainer's review. Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Jul 22, 2020
Copy link

@robotjellyzone robotjellyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this pr and its working in the way it should 👍

The changes made in this PR were tested locally. Following are the results:

  1. Code Review: Done

  2. All possible responses were tested as below:
    Screenshot/gif:
    tested-pr-gif

Expected Result: Search members by their name in the search bar
Actual Result: Same as above

  1. Additional testcases covered: n/a

Copy link

@robotjellyzone robotjellyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion @techno-disaster, i think it would be great if you can add this search functionality to that search symbol which is there on the right of the Members tab [and left of the settings button]. So that on just clicking that symbol at the top, one can directly do the searching of members.

@techno-disaster
Copy link
Contributor Author

@robotjellyzone yes, I planned to do that before but if you check mentorship-androod repo it was decided to have a new page for search functionality. This helps in UX.

@rpattath
Copy link
Member

@robotjellyzone would you mind adding this test to TestQuality. Ping me if you need help.

@rpattath rpattath added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. labels Jul 28, 2020
Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@isabelcosta
Copy link
Member

I'll merge this, I understand that @bartekpacia is busy these days. If you find anything that should be improved in this PR please raise an issue or let us know somehow (e.g.: Zulip).

@isabelcosta isabelcosta merged commit 0ecdeab into anitab-org:develop Aug 4, 2020
@techno-disaster techno-disaster deleted the search branch August 4, 2020 17:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: User Interface Improvements or additions to design. Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. Type: Enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MembersPage: add search feature
6 participants