-
Notifications
You must be signed in to change notification settings - Fork 59
Conversation
@anitab-org/qa-team can someone give this a quick test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Great work! @techno-disaster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this pr and its working in the way it should 👍
The changes made in this PR were tested locally. Following are the results:
Expected Result: Search members by their name in the search bar
Actual Result: Same as above
- Additional testcases covered: n/a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion @techno-disaster, i think it would be great if you can add this search functionality to that search symbol which is there on the right of the Members tab [and left of the settings button]. So that on just clicking that symbol at the top, one can directly do the searching of members.
@robotjellyzone yes, I planned to do that before but if you check mentorship-androod repo it was decided to have a new page for search functionality. This helps in UX. |
@robotjellyzone would you mind adding this test to TestQuality. Ping me if you need help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I'll merge this, I understand that @bartekpacia is busy these days. If you find anything that should be improved in this PR please raise an issue or let us know somehow (e.g.: Zulip). |
Description
Let other users search mentors and mentees using the search functionality :)
Fixes #38
Flutter Channel:
Type of Change:
Delete irrelevant options.
How Has This Been Tested?
Physical device. Adding video below
Checklist:
Delete irrelevant options.