feat: add loading indicator when changing password and saving profile #83

techno-disaster · 2020-05-21T23:52:56Z

Description

Add loading indicator on screen to help user understand what's happening.
If a user has a slow internet connection, the changing password request can take long and without a loading indicator he/she might think the apps stuck. Loading indicators will tell that the process is currently going on
Fixes #67
Fixes #94

Flutter Channel:

I have used the Flutter Beta channel on my local machine

Type of Change:

Delete irrelevant options.

User Interface

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Physical device. Check gif below

Checklist:

Delete irrelevant options.

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

My changes generate no new warnings

techno-disaster · 2020-05-21T23:54:09Z

@anitab-org/qa-team can someone test this?
Steps :
Change password, a loading indicator like in the gif should load up, until the snackbar comes up
Change something in Profile and save profile, a loading indicator should show up until the snacbar comes

lib/screens/home/pages/profile/profile_page.dart

lib/screens/settings/settings_screen.dart

bartekpacia · 2020-05-22T13:09:26Z

Great job overall👍

bartekpacia

Looks good.
EDIT: Looks I had a second reviewing screen opened in the second browser tab🤦‍♀️

techno-disaster · 2020-05-22T21:46:00Z

Looks good.

Still have to make some changes.

techno-disaster · 2020-05-27T22:35:40Z

Found one more page which can use loader and cleaned he code a bit

techno-disaster · 2020-05-27T22:47:11Z

I had to remove final from the bloc because I wanted to set the message to null, after we show the snackbar. without this the loader runs fine for the first time, but if the user hits send request again, then as state.message is not null anymore it wont enter the ifcase, and no snackbar will be shown + continuous loading.

bartekpacia

LGTM

techno-disaster · 2020-05-30T01:38:11Z

@isabelcosta can you review this too? 👀 Thanks

robotjellyzone

Looks good to me @techno-disaster ! just want to know why did you downgraded some of the versions in pubspec file ?

techno-disaster · 2020-06-08T17:36:23Z

Looks good to me @techno-disaster ! just want to know why did you downgraded some of the versions in pubspec file ?

The pubspec.lock is an auto generated file. We store all our dependencies in pubspec.yaml file.

techno-disaster · 2020-06-11T21:37:56Z

Working on #94 (It needs loading indicators as well). Lets review it after that's pushed too

lib/screens/send_request/bloc/send_request_state.dart

lib/screens/send_request/bloc/send_request_bloc.dart

lib/screens/home/pages/relation/relation_page.dart

bartekpacia

nice!

robotjellyzone · 2020-06-13T11:10:20Z

@anitab-org/qa-team can someone give this a quick test?
Thank You

I have tested this PR @techno-disaster as per your request . The needed feature is working as can be seen below :-

robotjellyzone · 2020-06-13T11:15:09Z

But I don't know why relation page isn't working as it can be seen from the following gif that all other pages are working but i am unable to see the relation page as its causing the app to crash ... with the following message on logcat -->

INFO: 2020-06-13 16:38:29.914830: Transition { currentState: RelationPageLoading, event: RelationPageShowed, nextState: RelationPageFailure }

robotjellyzone

May be the changes done in the relation page needs to be reviewed again 🤔 @techno-disaster ?

techno-disaster · 2020-06-13T16:53:08Z

@robotjellyzone thanks for reporting this, this happened when the user was not in a relationship, the issue is now fixed. Can you test again? i also added a loading indicator to the signUp page.

techno-disaster · 2020-06-15T23:39:49Z

@anitab-org/qa-team can anyone give this a quick test again? Thank You

robotjellyzone

Hi @techno-disaster i have tested the required feature & the relation page , everything is now working fine

great 👍

bartekpacia

Nice job :)

lib/widgets/loading_indicator.dart

techno-disaster · 2020-06-20T10:24:16Z

@anitab-org/mentorship-flutter-maintainers Can you take a quick look at this? The PR has been tested (all OK) just needs a quick review now

isabelcosta

Knowing very little about flutter, I am approving because this functionality seems to work.
@techno-disaster great work.
I am counting on other reviewers for code quality check. @bartekpacia you have to re-review after recent code changes.

techno-disaster · 2020-06-22T03:16:44Z

@bartekpacia could you check this again? previous review git dismissed due to the topcontext > topContext change

bartekpacia

thanks for using the camelCase, good job!

Techno-Disaster added 3 commits May 22, 2020 04:59

feat: add loading indicator when changing password & saving profile

380e468

cleanup

19055e2

disable interrupting process loading indicator

1e98fbb

techno-disaster requested review from bartekpacia and isabelcosta as code owners May 21, 2020 23:52

bartekpacia suggested changes May 22, 2020

View reviewed changes

lib/screens/home/pages/profile/profile_page.dart Outdated Show resolved Hide resolved

lib/screens/settings/settings_screen.dart Outdated Show resolved Hide resolved

bartekpacia previously approved these changes May 22, 2020

View reviewed changes

techno-disaster added the Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. label May 24, 2020

bartekpacia and others added 2 commits May 27, 2020 20:05

Merge branch 'develop' into issue-67-loading-indicators

a3ea951

cleaner code

f819dfb

techno-disaster dismissed bartekpacia’s stale review via f819dfb May 27, 2020 22:25

techno-disaster requested a review from bartekpacia May 27, 2020 22:47

bartekpacia previously approved these changes May 28, 2020

View reviewed changes

rpattath added Status: Needs Review PR needs an additional review or a maintainer's review. and removed Status: Needs Testing Work has been reviewed and needs the code tested by the quality assurance team. labels Jun 2, 2020

techno-disaster mentioned this pull request Jun 8, 2020

feat: add confirm password field and show passwords feature to change password popUp #92

Merged

7 tasks

robotjellyzone previously approved these changes Jun 8, 2020

View reviewed changes

techno-disaster mentioned this pull request Jun 11, 2020

Add Loading indicator when a task is created and marked as complete #94

Closed

techno-disaster added the Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. label Jun 11, 2020

Merge branch 'develop' into issue-67-loading-indicators

6d92165

techno-disaster dismissed stale reviews from robotjellyzone and bartekpacia via 6d92165 June 11, 2020 22:15

Gaurav192 reviewed Jun 12, 2020

View reviewed changes

lib/screens/send_request/bloc/send_request_state.dart Outdated Show resolved Hide resolved

reset snackbar message

afd1bd6

Gaurav192 reviewed Jun 12, 2020

View reviewed changes

lib/screens/send_request/bloc/send_request_bloc.dart Outdated Show resolved Hide resolved

CleanUp

50c32c6

HaripriyaB reviewed Jun 12, 2020

View reviewed changes

lib/screens/home/pages/relation/relation_page.dart Show resolved Hide resolved

HaripriyaB previously approved these changes Jun 12, 2020

View reviewed changes

bartekpacia previously approved these changes Jun 12, 2020

View reviewed changes

techno-disaster mentioned this pull request Jun 12, 2020

feat: make disabled text fields appear grey on profile page #99

Merged

7 tasks

robotjellyzone reviewed Jun 13, 2020

View reviewed changes

fix relation screen when not in a relation and add signUp page loader

d7ca66c

techno-disaster dismissed stale reviews from bartekpacia and HaripriyaB via d7ca66c June 13, 2020 16:51

techno-disaster requested review from bartekpacia and robotjellyzone June 13, 2020 16:53

robotjellyzone previously approved these changes Jun 16, 2020

View reviewed changes

bartekpacia previously approved these changes Jun 16, 2020

View reviewed changes

lib/widgets/loading_indicator.dart Show resolved Hide resolved

smol fix

21b2eaf

techno-disaster dismissed stale reviews from bartekpacia and robotjellyzone via 21b2eaf June 17, 2020 12:35

techno-disaster requested a review from bartekpacia June 17, 2020 12:37

isabelcosta approved these changes Jun 21, 2020

View reviewed changes

bartekpacia approved these changes Jun 22, 2020

View reviewed changes

techno-disaster merged commit e97fd3d into anitab-org:develop Jun 22, 2020

techno-disaster deleted the issue-67-loading-indicators branch June 22, 2020 09:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add loading indicator when changing password and saving profile #83

feat: add loading indicator when changing password and saving profile #83

techno-disaster commented May 21, 2020 •

edited

techno-disaster commented May 21, 2020

bartekpacia commented May 22, 2020

bartekpacia left a comment •

edited

techno-disaster commented May 22, 2020

techno-disaster commented May 27, 2020

techno-disaster commented May 27, 2020

bartekpacia left a comment

techno-disaster commented May 30, 2020

robotjellyzone left a comment •

edited

techno-disaster commented Jun 8, 2020

techno-disaster commented Jun 11, 2020

bartekpacia left a comment

robotjellyzone commented Jun 13, 2020

robotjellyzone commented Jun 13, 2020

robotjellyzone left a comment

techno-disaster commented Jun 13, 2020

techno-disaster commented Jun 15, 2020

robotjellyzone left a comment

bartekpacia left a comment

techno-disaster commented Jun 20, 2020

isabelcosta left a comment

techno-disaster commented Jun 22, 2020

bartekpacia left a comment

feat: add loading indicator when changing password and saving profile #83

feat: add loading indicator when changing password and saving profile #83

Conversation

techno-disaster commented May 21, 2020 • edited

Description

Flutter Channel:

Type of Change:

How Has This Been Tested?

Checklist:

techno-disaster commented May 21, 2020

bartekpacia commented May 22, 2020

bartekpacia left a comment • edited

Choose a reason for hiding this comment

techno-disaster commented May 22, 2020

techno-disaster commented May 27, 2020

Found one more page which can use loader and cleaned he code a bit

techno-disaster commented May 27, 2020

bartekpacia left a comment

Choose a reason for hiding this comment

techno-disaster commented May 30, 2020

robotjellyzone left a comment • edited

Choose a reason for hiding this comment

techno-disaster commented Jun 8, 2020

techno-disaster commented Jun 11, 2020

bartekpacia left a comment

Choose a reason for hiding this comment

robotjellyzone commented Jun 13, 2020

robotjellyzone commented Jun 13, 2020

robotjellyzone left a comment

Choose a reason for hiding this comment

techno-disaster commented Jun 13, 2020

techno-disaster commented Jun 15, 2020

robotjellyzone left a comment

Choose a reason for hiding this comment

bartekpacia left a comment

Choose a reason for hiding this comment

techno-disaster commented Jun 20, 2020

isabelcosta left a comment

Choose a reason for hiding this comment

techno-disaster commented Jun 22, 2020

bartekpacia left a comment

Choose a reason for hiding this comment

techno-disaster commented May 21, 2020 •

edited

bartekpacia left a comment •

edited

robotjellyzone left a comment •

edited