This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
feat: add helper text on requests page #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelcosta
previously approved these changes
May 15, 2020
isabelcosta
added
Status: Needs Review
bartekpacia
suggested changes
May 15, 2020
bartekpacia
suggested changes
May 17, 2020
| @@ -132,3 +119,17 @@ class _RequestsPageState extends State<RequestsPage> { | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| class NoRequestHelper extends StatelessWidget { | |||
There was a problem hiding this comment.
Great job.
I'd change NoRequestHelper -> NoRequestsInfo or NoRequestsText and we're good to go (because it's not really a helper)!
🎉💥
|
The iOS build is running since a hour and a half 😨 , I'll rerun it |
|
@isabelcosta can you approve this again? made some changes |
snitin315
approved these changes
May 19, 2020
shivaylamba
approved these changes
May 19, 2020
3 tasks
|
@anitab-org/qa-team can anyone test this? or @bartekpacia @snitin315 @shivaylamba |
isabelcosta
removed
the
Status: Needs Review
robotjellyzone
approved these changes
May 22, 2020
There was a problem hiding this comment.
It's working @isabelcosta !! great job @techno-disaster 🎉 👍
|
thanks for testing@robotjellyzone |
techno-disaster
added
Status: Needs Review
isabelcosta
approved these changes
May 22, 2020
There was a problem hiding this comment.
Sounds good then :)
Thank you @robotjellyzone for testing it!
isabelcosta
added
Status: Ready to Merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This block of code adds the helper text "you have {x} mentorship requests" to the requests page
Fixes #68
Flutter Channel:
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
On my physical device
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only