This repository has been archived by the owner on May 5, 2020. It is now read-only.
Unused XML schema declaration #1110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 4, 2018 22:35
|
@Rimjhim28 Please review my PR. |
There was a problem hiding this comment.
The changes to hardcoded strings look fine according to me.
@m-murad Could you pls have a look before this is approved?
Rimjhim28
reviewed
Apr 18, 2018
There was a problem hiding this comment.
@vaibhavi24 @m-murad The fix to hardcoded strings was already sent through PR #1050
The other change ( unused xml schema declaration ) is related to first timer issue #1102 and the PR is sent without any discussion.
@pprathameshmore Please follow instructions and guidelines.
I am closing the PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unused XML schema declaration
Fixes #1110 #1102
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
After removing unused XML schema declaration, I tested app on Android Emulator.
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only