This repository has been archived by the owner on May 5, 2020. It is now read-only.
fixed hardcoded text lint error #1102 #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rimjhim28
suggested changes
Jan 26, 2019
Rimjhim28
reviewed
Jan 26, 2019
Rimjhim28
suggested changes
Jan 28, 2019
hridyakrishna
force-pushed
the
powerup-#1102
branch
from
2c3f9cc
to
172df7a
Compare
|
Hello, @Rimjhim28 , I have done the changes requested. Please review this.Thank you. |
Rimjhim28
reviewed
Jan 31, 2019
Rimjhim28
reviewed
Jan 31, 2019
Rimjhim28
suggested changes
Jan 31, 2019
hridyakrishna
force-pushed
the
powerup-#1102
branch
from
172df7a
to
d573726
Compare
|
@Rimjhim28 I have squashed the commits. Please review. |
Rimjhim28
approved these changes
Feb 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the hardcoded texts using resources.
Fixes #1102
Type of Change:
How Has This Been Tested?
Application was built successfully in android studio without any errors.
Checklist:
Code/Quality Assurance Only