[CI] Ruby 2.3 and 2.5 #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @nicolasleger, can you explain your thinking behind this PR? |
|
Hey @ankane , ensure the gem tests pass on current maintained Ruby versions. |
|
Thanks @nicolasleger 👍 Since Ruby does a great job at maintaining backward compatibility, I don't think testing multiple versions adds much benefit. I also want to be mindful of Travis CI resources (and keep the test suite fast). |
|
I understand but there can be some incompatible changes between native Ruby 2.x or dependencies like |
|
It's definitely possible, but Groupdate hasn't had an issues with it. Certainly happy to reconsider if version-specific issues start popping up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.