Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with minimum supported, and latest Ruby #232

Closed
wants to merge 2 commits into from

Conversation

aried3r
Copy link

@aried3r aried3r commented Feb 19, 2020

Hey!

This is a proposal in the form of a PR, what do you think about this? Instead of testing all supported Ruby versions, we could test the required_ruby_version and the latest available.

Cheers and thanks for this gem!

@ankane
Copy link
Owner

ankane commented Feb 20, 2020

Hey @aried3r, thanks for the PR. See #194 for my thoughts on testing multiple Ruby versions. Will switch to 2.7 once a new version of Active Record is out that doesn't have all the deprecation warnings.

@aried3r
Copy link
Author

aried3r commented Feb 20, 2020

Hey, thanks for your reply and linking the issue! I was only searching in the history of the .travis.yml file for clues and only saw the removal of Ruby versions being tested.

I understand that Ruby is usually stable enough, but would you nevertheless be open to testing the lowest and highest supported versions? paper_trail does it like this as well (always a great argument!).

For us, specifically, it's important to know that all our dependencies work on Ruby 2.7 before we switch. Of course we could test locally, but why bother if we can do it automatically? :)
I get that the deprecation warnings are very noisy, but there's nothing this gem can do about it. But what can be done is make sure it works with Ruby 2.7 in an automated fashion and doesn't produce new deprecation warnings itself.

As for testing with 2.4, I don't have an argument, since we're on a higher version. Personally, I'd just like to know that if a gem says it supports ≥2.4, I can just check the CI if that is indeed the case. But again, the Ruby team has a good track record of not making breaking changes.

I have no strong feelings either way so I'm fine with closing this.

PS: As for speed, we could add cache: bundler, since bundle install seems to take around 20 seconds. Compare to paper_trail (similar setup and dependencies), which takes around 3 seconds with caching.

@ankane
Copy link
Owner

ankane commented Feb 23, 2020

Hey @aried3r, I appreciate the response, but I don't see a strong reason to change things right now.

@ankane ankane closed this Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants