Remove duplicated rake require #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be a duplicate process related to Rake. https://github.com/ankane/searchkick/blob/d7312a300e56c035dcbd217c27438c6ed5a6484a/lib/searchkick.rb#L22-L34
|
Thanks @y-yagi 👍 |
mikelkew
added a commit
to mikelkew/searchkick
that referenced
this pull request
May 16, 2018
* Searchkick_BASE/master: (275 commits) Version bump to 3.1.0 [skip ci] Revert "Use pluck for async reindex to avoid loading records in memory - ankane#1134" Use pluck for async reindex to avoid loading records in memory - ankane#1134 Symbolize keys for better merging - fixes ankane#1144 Show exact record ids that are missing [skip ci] Fixed with_hit and with_highlights when records in search index do not exist in database Check for hit highlight as well [skip ci] Fixed error with highlights and match all - fixes ankane#1140 Ability to exclude ids with similar method - fixes ankane#1139 Update README for factory_bot (ankane#1138) Updated comment [skip ci] Mode: true -> :inline [skip ci] Intermediate -> Inline [skip ci] Added :inline as alias for true for callbacks and mode options - closes ankane#1133 Remove duplicated rake require (ankane#1132) No need for regex [skip ci] Warn when records in search index do not exist in database Friendlier error message for bad mapping with partial matches - fixes ankane#1127 Support more boost_by_distance options Version bump to 3.0.3 ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a duplicate process related to Rake.
searchkick/lib/searchkick.rb
Lines 22 to 34 in d7312a3