Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): fix build issues #11096

Merged
merged 6 commits into from
Apr 26, 2022
Merged

Commits on Apr 25, 2022

  1. Configuration menu
    Copy the full SHA
    03978a8 View commit details
    Browse the repository at this point in the history
  2. perf(ci): use gradle-build-action w/main cache only on all workflows

    This should optimize LRU cache eviction so main and branches always have
    reasonably fresh gradle caches and main does not ever get evicted, since
    branches have independent caches and would otherwise fill up 10GB cache limit
    
    Note that `--daemon` is specified as the default for this action is no daemon,
    that is correct for long-lived runners to avoid cross-build contamination, but
    on GitHub Hosted Runners (which we use) we are clean each run, so this is a small
    optimization to share gradle between steps: gradle/gradle-build-action#113 (comment)
    mikehardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    a9c225c View commit details
    Browse the repository at this point in the history
  3. build(deps): lint-rules hamcrest use 2.2, extract hamcrest version

    This is the recommended way to upgrade hamcrest from 1.x to 2.x when
    using junit 4.x, see http://hamcrest.org/JavaHamcrest/distributables#gradle-upgrade-example
    mikehardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    69a603e View commit details
    Browse the repository at this point in the history
  4. fix(build): lint-rules project should use common best build practices

    extract our best-practices build settings to project-level file, apply
    to all sub-projects
    
    Fixes ankidroid#11083
    mikehardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    dd44e73 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. fix(build): assert that more than zero androidTests executed

    Sometimes an emulator "runs" tests, but it actually discovered zero
    tests, runs zero tests, and still reports success. Lookin' at you API21.
    
    Fixes ankidroid#11078
    mikehardy committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    bc86a19 View commit details
    Browse the repository at this point in the history
  2. build(deps): remove ktlint memory leak workaround

    It appears upstream has fixed the leak as of 0.45.0, so workaround
    not needed, and ktlint is now on 0.45.2 anyway, so use that
    
    Can't remove the actual version override that gets us 0.45.x until
    the ktlint gradle plugin has a new release but that hasn't happened yet
    mikehardy committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    83e97ce View commit details
    Browse the repository at this point in the history