New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use flags from col, dynamically loading them into the menu #16218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strings also differ in AnkiDroid i.e. the flag
after them but I am not focusing on that here, and if we wish to reuse addFlags
then I am all ears
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI issue
I just want to test id this test is really causing the issue, if not then I will revert the commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
19b0bc6
to
769d3ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Should be the last round
I'd also encourage adding a follow-up issue to change the strings from Red flag
to Red
as is used upstream
35f5b39
to
73a30d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One more to go
AnkiDroid/src/main/java/com/ichi2/anki/previewer/PreviewerFragment.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: David Allison <62114487+david-allison@users.noreply.github.com>
Purpose / Description
This PR removes the static menu item - flags, from the menu and dynamically load the flag data which allow the user to access the renamed flags if they did rename them in Anki desktop
Fixes
Approach
Loaded flag from col
How Has This Been Tested?
Anki ->
AnkiDroid ->
Checklist
Please, go through these checks before submitting the PR.