build(ci): upload logs on timeout #16255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A timeout can cancel tests, which blocks log uploads Issue 16253 https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif https://docs.github.com/en/actions/learn-github-actions/expressions#cancelled
|
This PR should not be merged yet, we should rerun it until the failure is replicated This both moves the linked issue along, and acts as a confirmation of PR functionality |
mikehardy
reviewed
Apr 23, 2024
| if: failure() | ||
| # cancelled() handles test timeouts | ||
| # remove when test timeouts cause a failure() | ||
| if: failure() || cancelled() |
There was a problem hiding this comment.
It appears it may be (untested) possible to do:
Suggested change
| if: failure() || cancelled() | |
| if: '!success()' |
...and catch every single case except success, but failure && cancelled also seems sufficient
|
I'll attempt to keep re-running the windows test any time I see it's green, until it goes red. Please anyone else that sees this with windows unit test run as green re-run it as well, the goal is to have it hang + cancel + upload the logs so until it has a red status here we want to re-run it |
|
This might go faster if the matrix was temporarily tweaked to be windows only for unit tests, and a separate just-for-matrix-expansion-only parameter was added to create like 20 windows runs at once Here is an example that creates the expansion (we would put And note later in the file the logs need that in their name or they clobber each other: |
|
I'm frazzled mentally, I can apply a patch at max, or I'll get the change done tomorrow |
|
output is a .bin file 😅 - not sure how to interpret, going to table for the moment it's end of day here too |
|
with some ==== I added lines starting with |
--> @criticalAY FYI ... I remember the day when long stacktraces used to faze me... those were the days 😅 |
5 tasks
|
But the col was open for other activities too, suspend fun getName(resources: Resources): String {
val overrides = withCol { config.getObject("flagLabels", JSONObject()) }
return overrides.getStringOrNull(code.toString()) ?: resources.getString(defaultNameRes)
} |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
5 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions
bot
removed
the
Review High Priority
|
slamming this one in outside of queue, queue is rejecting too frequently because of flakes and this is part of fixing the flakes |
|
This was a huge help! Really happy this is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A timeout can cancel tests, which blocks log uploads
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif
https://docs.github.com/en/actions/learn-github-actions/expressions#cancelled