Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate root build file to kotlin dsl #16451

Merged
merged 1 commit into from
May 24, 2024

Conversation

lukstbit
Copy link
Member

Purpose / Description

Migrates the root build gradle file to kotlin dsl.
Note: I've done this in a single commit as I don't think it's worth keeping the git history, it's almost only dependencies updates + some tweaks from Mike for CI. This avoids having a commit that doesn't compile in the git history.

How Has This Been Tested?

Synchronized/built the project.

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@lukstbit lukstbit force-pushed the refactor_kotlinDslMainModule branch 2 times, most recently from 20738e9 to ce99bf0 Compare May 22, 2024 09:20
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, treat this as an 'approve' once the macOS CI error is fixed.

I like git history, but build.gradle has always been a mess.
I'd have found this questionable if we had migrated to the version catalog sooner, but it's fine as it is

build.gradle.kts Outdated Show resolved Hide resolved
@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label May 22, 2024
Note: this is a single commit migration so it clears the git history
for the build file. I think this is acceptable as most history is about dependency updates.
@lukstbit lukstbit force-pushed the refactor_kotlinDslMainModule branch from ce99bf0 to 72531ac Compare May 23, 2024 18:29
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author labels May 23, 2024
@BrayanDSO BrayanDSO added this pull request to the merge queue May 24, 2024
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 24, 2024
Merged via the queue into ankidroid:main with commit c0f3ea9 May 24, 2024
8 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone May 24, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 24, 2024
@lukstbit lukstbit deleted the refactor_kotlinDslMainModule branch May 24, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants