Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new reviewer): implement some of the actions #16493

Merged
merged 13 commits into from
Jun 21, 2024
Merged

Conversation

BrayanDSO
Copy link
Member

@BrayanDSO BrayanDSO commented May 27, 2024

Purpose / Description

Implement in the new reviewer:

  1. Card info
  2. Deck Options
  3. Add note
  4. Edit note
  5. Bury
  6. Suspend
  7. Delete
  8. Flags
  9. User actions
  10. Undo
  11. Redo

Fixes

Part of #14302

Approach

They are implemented in separate commits, so they can be reviewed individually and split if necessary

Note: the Mark note and Flag icons are misaligned for some reason and will be fixed later

Adding Undo to the snackbar of some of the actions will also be done later

How Has This Been Tested?

Emulator 34

rev2.webm
rev21.webm
flag_mark.webm
user.action.webm
undo.redo.webm

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner
    rev21.webm

@BrayanDSO BrayanDSO force-pushed the rev2 branch 2 times, most recently from 136f1c9 to e182f64 Compare May 28, 2024 00:37
@snowtimeglass

This comment was marked as resolved.

@BrayanDSO

This comment was marked as resolved.

@snowtimeglass

This comment was marked as resolved.

@mikehardy
Copy link
Member

I think it's fine to defer work but I'm afraid of losing track of the state of the work if there are things that look really really close to complete (as much of this does) but has tiny things like two menu items slightly off center

Perhaps a comment on the main port PR (or a checkbox-list in the description?) where tiny things are tracked?

@BrayanDSO
Copy link
Member Author

The important TODOs are documented in the code.

Keeping a separate list would be mostly busywork to me at the moment, since most of the things aren't implemented yet. Maybe when this comes closer to be under a public-available experimental setting.

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev-only change. I'm happy

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jun 7, 2024
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!
Left some minor nitpicks plus there were changes in the flag area recently and this doesn't build at the moment.

@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Jun 12, 2024
@BrayanDSO
Copy link
Member Author

This needs me to update the flags to use the custom names.

@BrayanDSO BrayanDSO removed Needs Author Reply Waiting for a reply from the original author Has Conflicts labels Jun 20, 2024
@BrayanDSO BrayanDSO requested a review from lukstbit June 20, 2024 14:48
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, LGTM!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jun 21, 2024
@lukstbit lukstbit added this pull request to the merge queue Jun 21, 2024
Merged via the queue into ankidroid:main with commit a4f9f95 Jun 21, 2024
8 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Jun 21, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jun 21, 2024
@BrayanDSO BrayanDSO deleted the rev2 branch June 21, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants