-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Crop functionality #6543
Merged
Merged
Add Crop functionality #6543
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
3498209
NF: remove API15 remnants now that minSdkVersion is 16
mikehardy 22521e3
NF: extract saveAndExit from MultimediaEditFieldActivity
mikehardy 409ee80
NF: path variables, extract createNewFile/handleTakePictureResult
mikehardy 44426e5
Extract file path / URI conversions, make work across all APIs
mikehardy bc4d457
Add ability to crop image on user request and camera result return
mikehardy b2dd84d
Prompt user to crop on image edit return if images is large
mikehardy e11ce6a
Image crop feedback: JPG compress, "No" in dialogs, add comments
mikehardy 1f9c811
Only consider RESULT_OK as a positive image edit result
mikehardy a0791bf
Add Activity restart support to multimedia edit, implement for Image
mikehardy 2d847f1
Refactor crop dialog so one definition is reusable
mikehardy 3586444
NF: add annotations from super to subclass compat copy methods
mikehardy 1978f47
Improve messaging on unexpected crop results
mikehardy 7500e85
Improve image editor file handling
mikehardy ba7feb4
Improve error-handling in image edit on activity starts
mikehardy 8756fd4
Image edit can internalize ephemeral files now
mikehardy b146e9e
Fix incorrect change to URI generation on API<N
mikehardy c1c87a6
Use FileProvider-correct test for image test
mikehardy 408192f
Fully restore previous image on unsuccessful image edit
mikehardy f253f18
NF: image editor re-categorize logging, clean imports, remove @Suppress
mikehardy 30fa233
Image controller should treat all errors >= 1 as non-success
mikehardy 2e1f5ea
URI path/name resolution typed more strongly
mikehardy 0281280
NF: extract image revert handling (save, revert, delete) methods
mikehardy a4746f0
Image picker should be restricted to images only
mikehardy 2da041f
Image rotate and compress detects bad images, callers handle it
mikehardy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe go with
Formatter.formatShortFileSize
.You could bring the format string inside the resource.