Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: borders on fullscreen Reviewer #9278

Merged
merged 4 commits into from Jul 16, 2021
Merged

fix: borders on fullscreen Reviewer #9278

merged 4 commits into from Jul 16, 2021

Commits on Jul 16, 2021

  1. fix bug: wrong constant used

    @david-allison
    david-allison committed Jul 16, 2021
    Copy the full SHA
    420fb12 View commit details
    Browse the repository at this point in the history

  2. nf: Add enum: FullScreenMode 

    Refactoring requested in a review for clarity
    @david-allison
    david-allison committed Jul 16, 2021
    Copy the full SHA
    8c8c279 View commit details
    Browse the repository at this point in the history

  3. fix: borders on fullscreen Reviewer 

    When going fullscreen, the reviewer had white/blue borders rather than
filling the content

Cause:

d0d1edd moved to a single xml file for
the navigation drawer, rather than copy/pasting it into each file

Some layouts excluded `android:fitsSystemWindows="true"`, but the new
xml file always included this.

This caused the layout problems

fix: add method: fitsSystemWindows and layout without the variable

Fixes 9267
    @david-allison
    david-allison committed Jul 16, 2021
    Copy the full SHA
    3e01bbf View commit details
    Browse the repository at this point in the history

  4. nf: remove TODO from beta

    @david-allison
    david-allison committed Jul 16, 2021
    Copy the full SHA
    5beac3a View commit details
    Browse the repository at this point in the history