-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate switch to difflib #2305
Comments
We'll want to look into this as a matter of priority, as it appears that dissimilar will panic with certain non-Latin text input, eg
|
To be clear, that means the investigation part is over and we want to switch without question now? |
If the library isn’t suitable, there’s still the option of finding another
one, or trying to fix the panic in the one we currently use as a last resort
…On Tue, 10 Jan 2023 at 2:43 am RumovZ ***@***.***> wrote:
To be clear, that means the investigation part is over and we want to
switch without question now?
—
Reply to this email directly, view it on GitHub
<#2305 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMCPX6NSUQRSW3CYD3ENDWRQ53FANCNFSM6AAAAAATU6FGQI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Closed via #2322 |
Still incorrect in 2.1.57 |
Please create a new issue and describe the problems you're having/provide reproduction steps. |
Nevermind, I see you've posted in the forums. Please provide a card ID and the exact text you're entering, so I can try to reproduce the problem. https://forums.ankiweb.net/t/bug-cloze-correction-doesnt-work-as-expected/26302/3 |
1e0be26 migrated from the Python difflib to the dissimilar crate so we can use the code across all platforms, but it unfortunately does not seem to perform as well for some languages/inputs. There appears to be a Rust port of difflib available, so it might be worth looking into whether we can use that instead, if it gives better output.
https://crates.io/crates/difflib
https://forums.ankiweb.net/t/error-highlighting-after-typing-the-answer/25755/6
@RumovZ feel free to take this if it interests you
The text was updated successfully, but these errors were encountered: