Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile compatiblity with Make 3.81 #252

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

danmichaelo
Copy link
Contributor

@danmichaelo danmichaelo commented Jan 7, 2022

Turned out to be easy to fix #251 , it's just newline handling that has changed. It now works both with make 3.81 and 4.3:

$ rm ~/gocode/bin/golangci-lint
$ make lint
golangci/golangci-lint info checking GitHub for tag 'v1.43.0'
golangci/golangci-lint info found version: 1.43.0 for v1.43.0/darwin/amd64
golangci/golangci-lint info installed ~/gocode/bin/golangci-lint
golangci-lint run ./...

$ rm ~/gocode/bin/golangci-lint
$ gmake lint
golangci/golangci-lint info checking GitHub for tag 'v1.43.0'
golangci/golangci-lint info found version: 1.43.0 for v1.43.0/darwin/amd64
golangci/golangci-lint info installed ~/gocode/bin/golangci-lint

@realtime-neil
Copy link
Contributor

@danmichaelo with this change, you could probably also lose the GNUism .ONESHELL at the top.

@danmichaelo
Copy link
Contributor Author

@danmichaelo with this change, you could probably also lose the GNUism .ONESHELL at the top.

Interesting, that could very well be, but I'm not at all familiar with that option or why it's there, so I don't feel confident suggesting to remove it.

@ankitpokhrel
Copy link
Owner

@danmichaelo @realtime-neil .ONESHELL is only supported from 3.82. Mac is shipped with 3.81 and since we are not extensively relying on .ONESHELL, I am good with removing it for improved support.

@ankitpokhrel ankitpokhrel merged commit 27b6122 into ankitpokhrel:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make lint fails with make 3.81
3 participants