Support creating issues with custom subtask type #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the code was assuming only one sub-task type existed (the default). This would cause any issues filed with a custom sub-task type to fail with the following error: ``` Error: - Issue 'XXX-23668' must be of type 'Epic'. jira: Received unexpected response '400 Bad Request' ``` because `jira.CreateRequest::SubtaskField` was not being set. Fix by modifying `GetSubtaskHandle()` helper to look for exact matches on sub-task types.
ankitpokhrel
approved these changes
May 27, 2022
There was a problem hiding this comment.
Ran into same issue today and this seems to be working fine. Thank you for working on this @danobi 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the code was assuming only one sub-task type existed (the
default). This would cause any issues filed with a custom sub-task type
to fail with the following error:
because
jira.CreateRequest::SubtaskFieldwas not being set.Fix by modifying
GetSubtaskHandle()helper to look for exact matcheson sub-task types.