Set additional metadata in Upload-Metadata header #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitpokhrel
requested changes
May 18, 2019
There was a problem hiding this comment.
Hi @SamsamBabadi,
Thank you for contributing.
Could you please add tests for your changes? Also make sure to run cs-fixer as mentioned here. Ideally, your PR should not contain changes that are not related to your task. For eg this and this.
|
Oops. my mistake, I will fix those |
SamsamBabadi
force-pushed
the
master
branch
2 times, most recently
from
0cd6238
to
396bc33
Compare
samundra
reviewed
May 20, 2019
samundra
requested changes
May 20, 2019
|
I think everything is OK and you can accept this. |
ankitpokhrel
approved these changes
May 23, 2019
|
Thanks @SamsamBabadi ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://tus.io/protocols/resumable-upload.html#upload-metadata the Upload-Metadata header could contain multiple items.