Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Add ability to switch seamlessly between PHP7 and PHP8 #313

Merged
merged 2 commits into from
Nov 7, 2020

Conversation

ankitpokhrel
Copy link
Owner

This PR:

  • Removes PECL dependency by compiling apcu and xdebug manually. PECL (along with PEAR) is deprecated since PHP7.4 and might not be available in the future.
  • Removes unnecessary dependencies.
  • Adds a new make target clean.

This change will now allow us to switch between PHP7 and PHP8 just by changing the FROM directive in the base docker image. For eg: php:8.0.0RC3-fpm-alpine.

@ankitpokhrel ankitpokhrel added the dev/ci Changes in dev setup or CI label Nov 7, 2020
@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #313 (71eb811) into master (fa24517) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #313   +/-   ##
=========================================
  Coverage     99.68%   99.68%           
  Complexity      351      351           
=========================================
  Files            20       20           
  Lines           940      940           
=========================================
  Hits            937      937           
  Misses            3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa24517...71eb811. Read the comment docs.

@ankitpokhrel ankitpokhrel force-pushed the patch/compile-extensions-manually branch from 4030ab3 to 71eb811 Compare November 7, 2020 13:42
@ankitpokhrel ankitpokhrel merged commit cf97f64 into master Nov 7, 2020
@ankitpokhrel ankitpokhrel deleted the patch/compile-extensions-manually branch November 7, 2020 14:02
@ankitpokhrel ankitpokhrel mentioned this pull request Nov 7, 2020
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Changes in dev setup or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant