-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dota 2 plugin #71
Open
x89
wants to merge
92
commits into
anlutro:master
Choose a base branch
from
x89:dota2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dota 2 plugin #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added moop (this should go in config) gpm and xpm Typo with m/p api keys are long_text_style Let's show radiant/dire Remove pprint and close that bracket Remove this envs file, use config instead Get rid of envs and keep everything in the config anlutro/master run file Use the config for the api key That shouldn't have been there That can be global
Not done the dynamic config if that's a bloody necessity, rebase is a pain. |
why not merged yet |
Raziel please |
wew |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added moop (this should go in config)
gpm and xpm
Typo with m/p
api keys are long_text_style
Let's show radiant/dire
Remove pprint and close that bracket
Remove this envs file, use config instead
Get rid of envs and keep everything in the config
Use the config for the api key