[pull] main from microsoft:main #101
Open
+144,634
−89,283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Added tab color indicator for the tab switch menu. Tab color indicators have the same color as the background color of the tabs. If a tab has the default background color, the indicator is not shown in the tab switch menu. Closes #17465
This comment has been minimized.
This comment has been minimized.
…en (#15924) ## Summary of the Pull Request This commit fixes the middle mouse button handler. The `PointerReleased` callback is registered, but it is not operational because, on the Release event, the mouse button is no longer pressed. We need to track its state and act accordingly. Issue was introduced by commit 05e7ea1, which changed the event handler from `PointerPressed` to `PointerReleased`, rendering it inoperative. Instead, the default handler is used. The main issue is that when the close button is hidden with the `showCloseButton` option, the default handler no longer closes the tab on middle mouse clicks. Also made it consistent with the Settings tab, which was never converted to `PointerReleased` and is still handled with a custom handler. ## References and Relevant Issues Related commit 05e7ea1 ## Validation Steps Performed I've been using this commit locally for quite some time, figured out I might as well share it.
This comment has been minimized.
This comment has been minimized.
whoops. This should have been in preview after I sorted out #17366 ---- I did this one on GH so let's hope CI works
PackageES is deprecated by known scourge-on-earth OneBranch, and is now the cause of some non-compliance. I got permission from them to open-source it, so that's coming next. For now, we can just depend on a package based on our code based on theirs. Tested and working for C++ (DLL, EXE), C#, NuGet and MSIX.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The underlying issue is that the "Pane" is used both as a model and as a UI element and so a pane loses its content as soon as it is closed, but the tree only gets reordered after the animation has finished. This PR is truly just a hotfix, because it doesn't solve this issue, it only adds checks to the function that crashes. Closes #17869 Closes #17871 ## Validation Steps Performed * `Split pane` a few times * Run the "Close all other panes" action * Doesn't crash ✅
This comment has been minimized.
This comment has been minimized.
## Summary of the Pull Request This improves our `RIS` (hard reset) implementation, so it now also resets any changes that are made to the color table and color aliases, which is one of the things it's supposed to be doing. ## References and Relevant Issues This is also a small step towards implementing the `OSC` sequences that reset individual color table entries (issue #3719). ## Detailed Description of the Pull Request / Additional comments The way this works is by having a second copy of the color table and alias indices to hold the default values in the `RenderSettings` class. This default set is initially populated at startup with the user's chosen color scheme, but can also potentially be updated if the user changes their settings while a session is already in progress. When we receive an `RIS` request, we just copy the default values back over the active settings, and refresh the renderer. ## Validation Steps Performed I've manually tested both OpenConsole and Windows Terminal by changing my color scheme programmatically, and then confirming that the original colors are restored when an `RIS` sequence is received. I've also added some basic unit tests that check both the color aliases and color table are restored by `RIS`. ## PR Checklist - [x] Tests added/passed
This comment has been minimized.
This comment has been minimized.
We are, quite literally, shipping the org chart.
This comment has been minimized.
This comment has been minimized.
## Summary of the Pull Request Fixes some issues with truncated text in the settings UI when 200% text scaling is applied. For #17897, a minimum height was applied instead of a plain "height". This ensures that the desired height is applied in general, but under 200% text scaling, we are allowed to grow past that, thus preventing the truncation of the text. For #17898, flyouts have a scroll viewer inside them by default. We actually don't want the scroll viewer because that means the text will appear "truncated" when in reality, the user is expected to notice the small scrollbar and scroll horizontally (why that's the default, I will never know). This PR introduces a new style that can be applied to these flyouts to cause text wrapping instead of horizontal scrolling. Looked through the app for any instances where this happens. For #12006, simply changing the column width from a static value to "auto" fixes the issue. Frankly, we care more about the text appearing as a whole (and as whole words). The name of the actions wrap properly anyways. Closes #17897 Closes #17898 Closes #12006
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
## Summary of the Pull Request The sixel parser has an internal buffer that holds the indexed-color representation of the image, prior to it being translated to RGB. This buffer only retains the section of the image that is within the visible viewport, so we're continually erasing segments from the top of it when the image is large enough to trigger a scroll. But there is a problem that arises if the window or font is resized so that the buffer needs to reflow, because that can result in the image being pushed entirely offscreen. At that point the segment we're trying to erase is actually larger than the buffer itself, which can end up causing the terminal to crash To fix this, we just need to check for an oversized erase attempt and simply clear the buffer instead. ## Validation Steps Performed I could easily reproduce this crash in Windows Terminal by resizing the font while viewing an animated gif with img2sixel. With this PR applied the crash no longer occurs. ## PR Checklist - [x] Closes #17947
Because `_layoutLine` would never return `column == columnLimit` for control character visualizers, we'd get a deadlock in `_redisplay`, as it tries to fill the line until it's full, but never achieve it. Closes #17893 ## Validation Steps Performed * Press Ctrl-A to insert "^A" * Press Home to get to the start of the prompt * Press and hold "A" until the line wraps * The line wraps and there's no deadlock ✅
This comment has been minimized.
This comment has been minimized.
* Don't reset the position entirely when changing the needle * Don't change the scroll position when output arrives * Don't interfere with the search when output arrives constantly Closes #17301 ## Validation Steps Performed * In pwsh, run `10000..20000 | % { sleep 0.25; $_ }` * You can search for e.g. `1004` and it'll find 10 results. ✅ * You can scroll up and down past it and it won't snap back when new output arrives. ✅ * `while ($true) { Write-Host -NoNewline "`e[Ha"; sleep 0.0001; }` * You can cycle between the hits effortlessly. ✅ (This tests that the constantly reset `OutputIdle` event won't interfere.) * On input change, the focused result is near the previous one. ✅
This comment has been minimized.
This comment has been minimized.
Without a VT "renderer" there's no implicit output anymore when calling `ClearPseudoConsole`. The fix is trivial, but it works slightly different from before: Previously, we would preserve the line the cursor is on, while this PR doesn't do that. I felt like there's not much merit in preserving the line, because it may be a multi-line prompt which won't work with that. Closes #17867 ## Validation Steps Performed Bind 3 different actions to the 3 variants of "Clear buffer" and test them. They work. ✅
This comment has been minimized.
This comment has been minimized.
This adds a "defaultInputScope" setting, hooks it up to our TSF, and exposes it as a setting in the UI under the startup page. In order to stay close with the other language setting, I moved that one from the appearance to the startup page as well. 20 out of the 26 files in this PR are boilerplate unfortunately. Closes #17816 ## Validation Steps Performed * Install and use the Chinese IME * Launch WT * Chinese input ✅ * Change setting to `alphanumericHalfWidth` * Restart WT * English input ✅
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view or the 📜action log for details. Unrecognized words (177)Previously acknowledged words that are now absentAPCs Argb bitmasks changelists Cmts codepages distros flyouts gitlab Ioctl keydowns keyups nerror rectread reparented resultmacros scancodes subkeys testenvs titlebars tvtseq ul :arrow_right:To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands... in a clone of the git@github.com:microsoft/terminal.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/annihilatorrrr/terminal/actions/runs/11022031687/attempts/1'Errors (1)See the 📂 files view or the 📜action log for details.
See ❌ Event descriptions for more information. ✏️ Contributor please read thisBy default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later. If the listed items are:
See the 🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉 If the flagged items are 🤯 false positivesIf items relate to a ...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )